-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(contracts): modify Colosseum
tests related to V2
#363
test(contracts): modify Colosseum
tests related to V2
#363
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase onto base branch?
@@ -557,7 +557,9 @@ contract AssetManager is ISemver, IERC721Receiver, IAssetManager { | |||
unchecked { | |||
asset.totalKro += baseReward; | |||
asset.validatorKro += validatorReward; | |||
asset.rewardPerKghStored += boostedReward / asset.totalKgh; | |||
if (boostedReward > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If boostedReward is greater than 0, asset.totalKgh
is not zero. But why don't we check if the asset.totalKgh
is zero or not directly?
c6f716f
to
6baf418
Compare
b70a4e3
into
feat/implement-validator-system-v2
Description
Modified some tests of
Colosseum
related to V2. Also fixed the logic that stores boosted reward inAssetManager
to avoid divide by zero error.