Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): bond validator KRO #347

Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat(contracts): bond validator KRO #347

merged 3 commits into from
Jul 19, 2024

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented Jul 18, 2024

Description

Bond validator KRO during output submission and challenge creation.

@seolaoh seolaoh self-assigned this Jul 18, 2024
@seolaoh seolaoh requested a review from a team as a code owner July 18, 2024 06:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seolaoh seolaoh force-pushed the feat/bond-validator-kro branch from 58a6ba5 to 21eb1a5 Compare July 18, 2024 08:01
@0xHansLee 0xHansLee mentioned this pull request Jul 18, 2024
Merged
0xHansLee
0xHansLee reviewed Jul 18, 2024
View reviewed changes
packages/contracts/contracts/L1/AssetManager.sol Outdated
* ValidatorManager.MIN_ACTIVATE_AMOUNT.
*/
uint128 public immutable MIN_SLASHING_AMOUNT;
uint128 public immutable SLASHING_AMOUNT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we name this, BOND_AMOUNT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also it would be better for code readability

packages/contracts/contracts/L1/AssetManager.sol Outdated
Comment on lines 682 to 683
if (vault.asset.validatorKro - vault.asset.validatorKroBonded < SLASHING_AMOUNT)
revert InsufficientAsset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take out this from unchecked statement. Underflow can happen.

packages/contracts/contracts/L1/AssetManager.sol Outdated
Comment on lines 687 to 691
emit ValidatorKroBonded(
validator,
SLASHING_AMOUNT,
vault.asset.validatorKro - vault.asset.validatorKroBonded
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

packages/contracts/contracts/L1/interfaces/IAssetManager.sol
*
* @param validator Address of the validator.
* @param amount The amount of KRO bonded.
* @param remainder The remaining amount of validator KRO excluding bonded KRO.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good.

@seolaoh seolaoh requested review from 0xHansLee and sm-stack July 18, 2024 09:20
sm-stack
sm-stack approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@sm-stack sm-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh merged commit a7529b0 into feat/implement-validator-system-v2 Jul 19, 2024
1 of 2 checks passed
@seolaoh seolaoh deleted the feat/bond-validator-kro branch July 19, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm-stack sm-stack sm-stack approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

Assignees

@seolaoh seolaoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seolaoh @0xHansLee @sm-stack