chore(contracts): add token deployments for Sepolia, Kroma Sepolia #338
Conversation
WalkthroughThe changes predominantly focus on updating the deployment logic of deterministic proxies and improving clarity in logging messages. In Changes
Sequence DiagramssequenceDiagram
participant User
participant deploy-utils.ts
participant EthProvider
User->>deploy-utils.ts: call deployDeterministicProxy()
deploy-utils.ts->>EthProvider: Retrieve proxy build info and artifact
EthProvider-->>deploy-utils.ts: Proxy build info and artifact data
deploy-utils.ts->>deploy-utils.ts: Extract compiled output
deploy-utils.ts->>EthProvider: Deploy proxy and get transaction receipt
EthProvider-->>deploy-utils.ts: Deployment transaction receipt
deploy-utils.ts->>User: Return proxy deployment details
sequenceDiagram
participant User
participant forge-verify.ts
User->>forge-verify.ts: Execute verification task
forge-verify.ts->>forge-verify.ts: Log outcome with corrected message
forge-verify.ts->>User: Display verification status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (11)
packages/contracts/deploy-config/sepolia.jsonis excluded by!**/*.jsonpackages/contracts/deployments/kromaSepolia/GovernanceToken.jsonis excluded by!**/*.jsonpackages/contracts/deployments/kromaSepolia/GovernanceTokenProxy.jsonis excluded by!**/*.jsonpackages/contracts/deployments/kromaSepolia/MintManager.jsonis excluded by!**/*.jsonpackages/contracts/deployments/kromaSepolia/solcInputs/1cc21f973aa4cfc73d832518987f54f8.jsonis excluded by!**/*.jsonpackages/contracts/deployments/kromaSepolia/solcInputs/37a0cebac478897ae0c20446c8a2494a.jsonis excluded by!**/*.jsonpackages/contracts/deployments/sepolia/L1GovernanceToken.jsonis excluded by!**/*.jsonpackages/contracts/deployments/sepolia/L1GovernanceTokenProxy.jsonis excluded by!**/*.jsonpackages/contracts/deployments/sepolia/L1MintManager.jsonis excluded by!**/*.jsonpackages/contracts/deployments/sepolia/solcInputs/1cc21f973aa4cfc73d832518987f54f8.jsonis excluded by!**/*.jsonpackages/contracts/deployments/sepolia/solcInputs/37a0cebac478897ae0c20446c8a2494a.jsonis excluded by!**/*.json
Files selected for processing (2)
- packages/contracts/src/deploy-utils.ts (1 hunks)
- packages/contracts/tasks/forge-verify.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/contracts/tasks/forge-verify.ts
Additional comments not posted (7)
packages/contracts/src/deploy-utils.ts (7)
306-307: Introduce new ABI definition.The new ABI definition
create2DeployerAbiis correctly introduced for thedeployfunction.
309-311: Instantiate contract with new ABI.The contract instantiation with the new ABI
create2DeployerAbiis correctly done.
314-314: Connect contract with signer.The contract is correctly connected to the signer.
317-318: Deploy contract using CREATE2.The deployment call using
create2Deployer.deployis correctly performed and the transaction is awaited.
323-326: Retrieve and parse proxy build information.The retrieval and parsing of the proxy build information are correctly performed. This includes getting the build info, reading the artifact, and extracting the compiled output.
328-330: Retrieve deployment transaction receipt.The transaction receipt for the deployment is correctly retrieved.
335-338: Update proxy deployment object with new metadata.The proxy deployment object is correctly updated to include the transaction hash, deployment arguments, and metadata.
seolaoh
force-pushed
the
chore/add-token-deployments-sepolia
branch
from
efbd129 to
d7193ee
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/contracts/src/deploy-utils.ts (1 hunks)
- packages/contracts/tasks/forge-verify.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/contracts/src/deploy-utils.ts
Additional comments not posted (1)
packages/contracts/tasks/forge-verify.ts (1)
160-160: Corrected typo in log message.The log message typo has been corrected from "unsuccesful" to "unsuccessful".
Description
Deployed
GovernanceToken,MintManageron Sepolia and Kroma Sepolia. Also minted and distributed the token to trusted validator and security council owners.Additionally, to verify the contract on block explorer, the contracts deployments need metadata and constructor arguments. Added the extra data during saving deterministic proxy deployments in deploy script.