-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): add subcommands for the new validator system #302
feat(validator): add subcommands for the new validator system #302
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
340e463
to
07ef6fd
Compare
26b4f56
to
453aeeb
Compare
bf222a9
to
37d892a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make a README.md for the instruction of these commands?
The instruction will also be able to be used for our documents.
Good idea, I'll add one. |
453aeeb
to
b97ee89
Compare
37d892a
to
229ecef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name of package. I think validator
would be better.
9f98e21
to
5544e3f
Compare
3ee17ee
to
fdc3f1f
Compare
fdc3f1f
to
a42d405
Compare
905df94
to
320f3a6
Compare
b30b006
to
bc59abe
Compare
320f3a6
to
02b2e77
Compare
bc59abe
to
d459839
Compare
02b2e77
to
3ad1c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f2c08a0
to
c0adc23
Compare
f3c33ad
to
d68ca4b
Compare
Can you test these subcommands in local devnet? |
c0adc23
to
5931c37
Compare
d68ca4b
to
ba373b4
Compare
5931c37
to
07dd2b2
Compare
ba373b4
to
f1d1e86
Compare
7942dad
to
b9bec16
Compare
8537c8d
to
395d62b
Compare
I think the docker service name and cli app name are the same, which can be confusing when using the command line. Why not use a more feature-centric name for the cli app, like validator-controller. |
395d62b
to
f9b0e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b9bec16
to
6c80279
Compare
f9b0e2b
to
8bdf892
Compare
8bdf892
to
19982e8
Compare
Description
Implemented subcommands for the new validator system.