Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validator): add subcommands for the new validator system #302

Merged

Conversation

sm-stack
Copy link
Contributor

Description

Implemented subcommands for the new validator system.

@sm-stack sm-stack self-assigned this Apr 17, 2024
Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sm-stack sm-stack requested a review from a team April 17, 2024 09:28
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from 340e463 to 07ef6fd Compare April 18, 2024 03:59
@sm-stack sm-stack requested a review from a team as a code owner April 18, 2024 03:59
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch 3 times, most recently from 26b4f56 to 453aeeb Compare April 18, 2024 15:45
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from bf222a9 to 37d892a Compare April 18, 2024 15:58
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a README.md for the instruction of these commands?
The instruction will also be able to be used for our documents.

@sm-stack
Copy link
Contributor Author

Could you make a README.md for the instruction of these commands? The instruction will also be able to be used for our documents.

Good idea, I'll add one.

@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from 453aeeb to b97ee89 Compare April 19, 2024 08:37
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from 37d892a to 229ecef Compare April 19, 2024 08:39
kroma-validator/cmd/balance/cmd.go Outdated Show resolved Hide resolved
kroma-validator/cmd/balance/cmd.go Outdated Show resolved Hide resolved
kroma-validator/cmd/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name of package. I think validator would be better.

kroma-validator/cmd/balance/cmd.go Outdated Show resolved Hide resolved
kroma-validator/cmd/main.go Outdated Show resolved Hide resolved
kroma-validator/cmd/main.go Show resolved Hide resolved
kroma-validator/cmd/balance/cmd.go Outdated Show resolved Hide resolved
kroma-validator/cmd/balance/cmd.go Outdated Show resolved Hide resolved
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from 9f98e21 to 5544e3f Compare April 22, 2024 14:00
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch 2 times, most recently from 3ee17ee to fdc3f1f Compare April 23, 2024 05:23
@sm-stack sm-stack requested review from Pangssu and 0xHansLee April 23, 2024 06:02
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from fdc3f1f to a42d405 Compare April 23, 2024 06:17
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch 2 times, most recently from 905df94 to 320f3a6 Compare April 23, 2024 16:42
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from b30b006 to bc59abe Compare April 24, 2024 02:18
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from 320f3a6 to 02b2e77 Compare April 24, 2024 02:21
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from bc59abe to d459839 Compare April 24, 2024 02:27
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from 02b2e77 to 3ad1c5d Compare April 24, 2024 04:56
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sm-stack sm-stack force-pushed the feat/implement-validator-client branch 3 times, most recently from f2c08a0 to c0adc23 Compare April 26, 2024 04:49
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from f3c33ad to d68ca4b Compare April 26, 2024 04:58
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/validator/cmd.go Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
kroma-validator/cmd/README.md Outdated Show resolved Hide resolved
@seolaoh
Copy link
Contributor

seolaoh commented Apr 26, 2024

Can you test these subcommands in local devnet?

@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from c0adc23 to 5931c37 Compare April 26, 2024 07:40
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from d68ca4b to ba373b4 Compare April 26, 2024 09:35
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from 5931c37 to 07dd2b2 Compare April 26, 2024 09:37
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from ba373b4 to f1d1e86 Compare April 26, 2024 09:37
@sm-stack sm-stack force-pushed the feat/implement-validator-client branch 2 times, most recently from 7942dad to b9bec16 Compare April 26, 2024 13:14
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch 3 times, most recently from 8537c8d to 395d62b Compare April 27, 2024 09:50
@kangsorang
Copy link
Contributor

I think the docker service name and cli app name are the same, which can be confusing when using the command line. Why not use a more feature-centric name for the cli app, like validator-controller.

@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from 395d62b to f9b0e2b Compare April 29, 2024 05:47
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sm-stack sm-stack force-pushed the feat/implement-validator-client branch from b9bec16 to 6c80279 Compare April 29, 2024 07:39
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from f9b0e2b to 8bdf892 Compare April 29, 2024 07:46
Base automatically changed from feat/implement-validator-client to feat/implement-validator-system-v2 April 29, 2024 08:16
@sm-stack sm-stack force-pushed the feat/add-validator-subcommands branch from 8bdf892 to 19982e8 Compare April 29, 2024 08:28
@sm-stack sm-stack merged commit a5a8009 into feat/implement-validator-system-v2 Apr 29, 2024
2 checks passed
@sm-stack sm-stack deleted the feat/add-validator-subcommands branch April 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants