Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docker-compose<network>.yml #48

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Conversation

amis13
Copy link
Contributor

@amis13 amis13 commented Aug 25, 2024

I have updated the files removing the versions of the docker-compose, since they are not required and the warning pops up, this way we avoid the warning.

Fixes #48

amis13 and others added 7 commits April 25, 2024 15:39
deleting `git checkout tags/v1.4.2`
adding:
`git fetch origin`

by @0xHansLee

Co-authored-by: Hansol Lee <38912532+0xHansLee@users.noreply.github.com>
adding:
`git checkout v1.4.2`
Updating docker-compose-mainnet.yml
Updating docker-compose-sepolia.yml
@0xHansLee 0xHansLee requested review from wo-o and ccrayz August 28, 2024 01:20
@wo-o
Copy link
Contributor

wo-o commented Aug 28, 2024

@amis13 Can you share what warning you are getting with the log or screenshot? And also kindly check you docker, docker compose version.

@amis13
Copy link
Contributor Author

amis13 commented Aug 28, 2024

@amis13 Can you share what warning you are getting with the log or screenshot? And also kindly check you docker, docker compose version.

You can check here, it's the same warn:
https://forums.docker.com/t/docker-compose-yml-version-is-obsolete/141313

Later i'll send you the versions, but I use the latest version.

Copy link
Contributor

@wo-o wo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wo-o wo-o merged commit b54e706 into kroma-network:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants