feat: add fee distribution via L1Block contract #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangssu
force-pushed
the
feat/add-fee-distribution
branch
from
7bab8a2
to
b509b4b
Compare
chokobole
reviewed
Apr 26, 2023
Pangssu
force-pushed
the
feat/add-fee-distribution
branch
from
b509b4b
to
96b5125
Compare
chokobole
reviewed
Apr 26, 2023
Pangssu
force-pushed
the
feat/add-fee-distribution
branch
from
96b5125
to
7cab997
Compare
chokobole
reviewed
Apr 26, 2023
| @@ -432,19 +432,28 @@ func (st *StateTransition) innerTransitionDb() (*ExecutionResult, error) { | |||
| effectiveTip = cmath.BigMin(st.gasTipCap, new(big.Int).Sub(st.gasFeeCap, st.evm.Context.BaseFee)) | |||
| } | |||
|
|
|||
| gasUsed := new(big.Int).SetUint64(st.gasUsed()) | |||
| kromaConfig := st.evm.ChainConfig().Kroma | |||
| blockNum := st.evm.Context.BlockNumber.Uint64() | |||
There was a problem hiding this comment.
Strictly speaking, this is only used when kromaConfig != nil but you don't have to follow this. because it's too minor
DepositTx updates the ValidatorRewardRatio in the L1Block contract, which is used to distribute the tx fee to ProtocolVault and ValidatorRewardVault.
Pangssu
force-pushed
the
feat/add-fee-distribution
branch
from
7cab997
to
3afff8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DepositTx updates the ValidatorRewardRatio in the L1Block contract, which is used to distribute the tx fee to ProtocolVault and ValidatorRewardVault.