-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: postpone devnet KromaMPT time #140
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request involves a configuration update in the Changes
The modification represents a timestamp adjustment for the Kroma Devnet chain's MPT configuration, likely reflecting a planned network upgrade or timing change. Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)params/superchain.go (1)
The updated timestamp (1735534800) aligns with the PR objective to postpone the Kroma MPT time to December 30, 2024. No issues detected with this change. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -32,7 +32,7 @@ var KromaChainConfigs = map[uint64]*KromaChainConfig{ | |||
KromaDevnetChainID: { | |||
CanyonTime: uint64ptr(1707292800), | |||
EcotoneTime: uint64ptr(1712908800), | |||
KromaMPTTime: uint64ptr(1735189200), | |||
KromaMPTTime: uint64ptr(1735534800), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the time should be located at the point after the upgrade to v0.6.0, maybe Tuesday 2pm or Thursday 2pm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then I think Thursday seems like a good option.
1735534800 (2024-12-30 5:00:00 AM)