Vector support #179
Closed
Vector support #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
force-pushed
the
vector-support
branch
3 times, most recently
from
f4f260c
to
8d2e350
Compare
krojew
requested changes
May 8, 2024
| pub count: usize, | ||
| } | ||
|
|
||
| pub fn get_vector_type_info(option_value: &ColTypeOptionValue) -> Result<VectorInfo> { |
There was a problem hiding this comment.
Please don't use panicking functions or panic itself, since we're already using a Result.
cassandra-protocol/src/macros.rs
Outdated
| fn as_rust_type(&self) -> Result<Option<Vec<f32>>> { | ||
| let mut result: Vec<f32> = Vec::new(); | ||
| for data_value in &self.data { | ||
| let float = decode_float(data_value.as_slice().unwrap())?; |
cassandra-protocol/src/macros.rs
Outdated
| value, | ||
| } => { | ||
| let VectorInfo { internal_type, .. } = | ||
| get_vector_type_info(&value.as_ref().unwrap()).unwrap(); |
| let VectorInfo { | ||
| internal_type: _, | ||
| count, | ||
| } = get_vector_type_info(value).unwrap(); |
| @@ -151,6 +151,21 @@ pub fn decode_list(bytes: &[u8], version: Version) -> Result<Vec<CBytes>, io::Er | |||
| Ok(list) | |||
| } | |||
|
|
|||
| pub fn decode_vector( | |||
There was a problem hiding this comment.
This should be explicitly named as decoding floats, since a Vector can have any internal type.
krojew
requested changes
May 20, 2024
| let wrapper = wrapper_fn(&ColType::Float); | ||
|
|
||
| let convert = self.map(|bytes| { | ||
| wrapper(bytes, &internal_type_option, protocol_version).unwrap() |
| match $data_type_option.id { | ||
| ColType::Custom => match $data_value.as_slice() { | ||
| Some(ref bytes) => { | ||
| let crate::types::vector::VectorInfo { internal_type: _, count } = crate::types::vector::get_vector_type_info($data_type_option.value.as_ref().unwrap()).unwrap(); |
| let vector = decode_float_vector(actual_bytes, version, count) | ||
| .map(|data| Some(Vector::new(col_type.clone(), data, version))) | ||
| .expect("could not decode vector") | ||
| .unwrap() |
| if let Some(actual_bytes) = bytes.as_slice() { | ||
| let vector = decode_float_vector(actual_bytes, version, count) | ||
| .map(|data| Some(Vector::new(col_type.clone(), data, version))) | ||
| .expect("could not decode vector") |
|
Hi, any chance of making requested changes? |
|
issues fixed in #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for decoding Cassandra v5's new
VECTORtypes.https://cassandra.apache.org/_/blog/Apache-Cassandra-5.0-Features-Vector-Search.html