fix Compression to_string and into string impls #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krojew
requested changes
Jan 19, 2024
| match self { | ||
| Compression::Lz4 => write!(fmt, "lz4"), | ||
| Compression::Snappy => write!(fmt, "snappy"), | ||
| Compression::None => write!(fmt, "none"), |
There was a problem hiding this comment.
This is inconsistent with the implementation above.
|
I proposed this change so that the |
|
In Rust typically string representations of enums reflect the names itself. I think it would be better to explicitly add |
krojew
requested changes
Feb 12, 2024
| @@ -64,7 +63,7 @@ impl Clone for CompressionError { | |||
| } | |||
|
|
|||
| /// Enum which represents a type of compression. Only non-startup frame's body can be compressed. | |||
| #[derive(Debug, PartialEq, Clone, Copy, Eq, Ord, PartialOrd, Hash, Display)] | |||
| #[derive(Debug, PartialEq, Clone, Copy, Eq, Ord, PartialOrd, Hash)] | |||
krojew
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.