Create workflows #216
Create workflows #216
Conversation
|
@nschloe In your Github action workflows for the projects that use pybind11, you don't install pybind11 in the CI script, right? Would this still work with previous Python versions (other than 3.9)? |
Not explicitly, right. It's declared as a dependency in pyproject.toml (because it's needed when setuptools runs). |
|
Looks like I just have to delete the CircleCI stuff now. |
.github/workflows/testing.yml
Outdated
| sudo apt-get install -y python3-pip | ||
| sudo apt install -y libopenmpi3 libopenmpi-dev openmpi-bin | ||
| sudo apt install -y libhdf5-dev | ||
| pip install .[io] --user |
There was a problem hiding this comment.
No need to install pip or seismicmesh -- tox will handle it all.
There was a problem hiding this comment.
thanks, that's right. done.
.github/workflows/testing.yml
Outdated
| - name: Lint with black | ||
| run: | | ||
| pip install black | ||
| black --check . |
There was a problem hiding this comment.
It might be worthwhile separating out the linting. Not necessary to repeat that for every Python version.
There was a problem hiding this comment.
okay good point. don't want overwhelm github actions.
No description provided.