Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valgrind warnings #300

Open
yamadapc opened this issue Aug 12, 2024 · 0 comments
Open

Valgrind warnings #300

yamadapc opened this issue Aug 12, 2024 · 0 comments

Comments

@yamadapc
Copy link

yamadapc commented Aug 12, 2024 •
edited
Loading

Running a few tests under valgrind produces the following warnings:

Conditional jump or move depends on uninitialised value(s)

lmdb-js/src/lmdb-js.h

Line 354 in 89032ed

time_t lastReaderCheck;

lastReaderCheck has no initialization ; I reckon what it is initialized with is undefined behaviour.

Mismatched free / delete / delete[]

Warning about free call on:

lmdb-js/src/lmdb-js.h

Line 320 in 89032ed

static thread_local std::vector<EnvWrap*>* openEnvWraps;

openEnvWraps is a vector allocated with new on

lmdb-js/src/env.cpp

Line 390 in 89032ed

openEnvWraps = new std::vector<EnvWrap*>;

free won't call the destructor so I think this is leaking memory as the vector internals won't be released.
kriszyp added a commit that referenced this issue Aug 20, 2024
@kriszyp
Address valgrind warnings to properly initializer lastReaderCheck and…
9289b4d 
… delete the open envs vector, #300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yamadapc