Added support for Packer

[maximilian-walter]

I added the Filter PackerFilter which uses the PHP-Port of Dean Edwards's Packer to compress JavaScript.

[stof]

please use spaces for the indentation, not tabs

[maximilian-walter]

Done! Thanks for the feedback.

[kriswallsmith]

Looks good to me. Could you please add a test for this filter? This is a good example:
https://github.com/kriswallsmith/assetic/blob/master/tests/Assetic/Test/Filter/CssMinFilterTest.php

[maximilian-walter]

Is still something missing? :)

[kriswallsmith]

Sorry, I wasn't notified when you added this commit. I will review soon. Thanks!

[stof]

github never notifies when new commits are pushed in a PR.

[kriswallsmith]

oui

[everzet]

Oh, this american accent :-D

[maximilian-walter]

Good to know. I didn't know that, sorry.

[kriswallsmith]

Yeah, it's a good idea to post a comment when you push to a PR to notify the folks subscribed.

[stof]

@kriswallsmith is there anything missing according to you ?

[kriswallsmith]

Please add the $_SERVER var to phpunit.xml.dist and we're all set.

[stof]

And please add it in the Travis setup (you will need to rebase your branch to have it) so that Travis clones the needed repo and can run the test

[maximilian-walter]

Okay, seems that I need some help here... I have done a rebase on my local repository:

git fetch upstream
git rebase upstream/master

But now I can't push it to GitHub...

 ! [rejected]        master -> master (non-fast forward)
 error: failed to push some refs to 'git@github.com:maximilian-walter/assetic.git'

What should I do now?

[stof]

you need to force the push of the branch. A simple push will fail and this is logical as you rewrote the history (git tries to avoid you doing mistakes if you did not want to rewrite it)

git push origin master --force

[stof]

@maximilian-walter ping. Could you rebase your branch ?

Btw, it would be great to add Packer to the vendors downloaded during the travis setup (and adding the path in the travis phpunit config) so that the test does not need to be skipped.

[stof]

@maximilian-walter ping

[maximilian-walter]

Sorry, I was very busy the last time. I could rebase my branch and added Packer to the Travis setup, thanks for your help. Can you check it, please.

[stof]

wrong indentation (which will break things as it makes the YAML invalid)

[maximilian-walter]

The wrong indentation is fixed!

[stof]

Thanks

[FredoVelcro-zz]

Can someone help me to configure this filter in Symfony2 ?
Thanks a lot ! ;)