Changed bundler to Rollup #367
Conversation
- Added ES6 modules for bundlers and browsers (fixed #262) - Added CommonJS - Added UMD - Name change so that .min actually reflects the minified version
|
I love it! Great work! |
README.md
Outdated
|
|
||
| | | UMD | CommonJS | ES Module (for bundlers) | ES Module (for browsers) | | ||
| | --------------------- | ----------- | -------------- | ------------------------ | ------------------------ | | ||
| | **Full** | fuse.js | fuse.common.js | fuse.esm.js | fuse.esm.browser.js | |
There was a problem hiding this comment.
I'm not understanding why fuse.esm.js might be needed. Bundlers can use fuse.esm.browser.js, right?
There was a problem hiding this comment.
Just added the explanation here.
Does it clarify things?
There was a problem hiding this comment.
Not quite. I looked at both dist/fuse.esm.js and dist/fuse.esm.browser.js, there isn't much difference that could be used for tree shaking (there is a single default export in both). The only difference I saw is fuse.esm.js is transpiled, while browser one is not. When people are using bundlers, they often use transpilers along with it. So we shouldn't need a fuse.esm.js (and rename fuse.esm.browsers.js to fuse.esm.js), unless I'm missing something.
There was a problem hiding this comment.
Slightly late to mention, but having a fuse.esm.min.js would be nice to have (for browsers).
Thanks for working on it though! 😻
There was a problem hiding this comment.
I can add it as part of v5.2.0
Ok, a bunch of goodies here:
cc: @KonradHoeffner @sidvishnoi @cshoredaniel