fix: auto save when component def changes (ToolJet#2638)

* fix: auto save when component def changes * remove callback
krishnam1998gkp · Mar 25, 2022 · d45ef48 · d45ef48
1 parent 2e62d74
commit d45ef48
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 26 deletions.
diff --git a/frontend/src/Editor/Editor.jsx b/frontend/src/Editor/Editor.jsx
@@ -503,8 +503,9 @@ class Editor extends React.Component {
       },
       this.handleAddPatch
     );
-
-    return setStateAsync(_self, newDefinition);
+    setStateAsync(_self, newDefinition).then(() => {
+      this.autoSave();
+    });
   };
 
   cloneComponent = (newComponent) => {

diff --git a/frontend/src/Editor/Inspector/Inspector.jsx b/frontend/src/Editor/Inspector/Inspector.jsx
@@ -162,30 +162,30 @@ export const Inspector = ({
         },
       };
 
-      componentDefinitionChanged(newComponent).then(() => {
-        //  Child componets should also have a mobile layout
-        const childComponents = Object.keys(allComponents).filter((key) => allComponents[key].parent === component.id);
-
-        childComponents.forEach((componentId) => {
-          let newChild = {
-            id: componentId,
-            ...allComponents[componentId],
-          };
-
-          const { width, height } = newChild.layouts['desktop'];
-
-          newChild['layouts'] = {
-            ...newChild.layouts,
-            mobile: {
-              top: 100,
-              left: 0,
-              width: Math.min(width, 445),
-              height: height,
-            },
-          };
-
-          componentDefinitionChanged(newChild);
-        });
+      componentDefinitionChanged(newComponent);
+
+      //  Child componets should also have a mobile layout
+      const childComponents = Object.keys(allComponents).filter((key) => allComponents[key].parent === component.id);
+
+      childComponents.forEach((componentId) => {
+        let newChild = {
+          id: componentId,
+          ...allComponents[componentId],
+        };
+
+        const { width, height } = newChild.layouts['desktop'];
+
+        newChild['layouts'] = {
+          ...newChild.layouts,
+          mobile: {
+            top: 100,
+            left: 0,
+            width: Math.min(width, 445),
+            height: height,
+          },
+        };
+
+        componentDefinitionChanged(newChild);
       });
     }
   }