fix: cli args

kriptohaberciniz · Feb 2, 2024 · 6843141 · 6843141
1 parent a183eea
commit 6843141
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/disperser/batcher/batcher.go b/disperser/batcher/batcher.go
@@ -51,7 +51,7 @@ type Config struct {
 	// BatchSizeMBLimit is the maximum size of a batch in MB
 	BatchSizeMBLimit     uint
 	MaxNumRetriesPerBlob uint
-	NumConfirmer         uint
+	ConfirmerNum         uint
 }
 
 type Batcher struct {

diff --git a/disperser/cmd/batcher/config.go b/disperser/cmd/batcher/config.go
@@ -43,7 +43,7 @@ func NewConfig(ctx *cli.Context) Config {
 			BatchSizeMBLimit:         ctx.GlobalUint(flags.BatchSizeLimitFlag.Name),
 			SRSOrder:                 ctx.GlobalInt(flags.SRSOrderFlag.Name),
 			MaxNumRetriesPerBlob:     ctx.GlobalUint(flags.MaxNumRetriesPerBlobFlag.Name),
-			NumConfirmer:             ctx.GlobalUint(flags.NumConfirmer.Name),
+			ConfirmerNum:             ctx.GlobalUint(flags.ConfirmerNumFlag.Name),
 		},
 		TimeoutConfig: batcher.TimeoutConfig{
 			EncodingTimeout:   ctx.GlobalDuration(flags.EncodingTimeoutFlag.Name),

diff --git a/disperser/cmd/batcher/flags/flags.go b/disperser/cmd/batcher/flags/flags.go
@@ -117,11 +117,11 @@ var (
 		EnvVar:   common.PrefixEnvVar(envVarPrefix, "MAX_NUM_RETRIES_PER_BLOB"),
 		Value:    2,
 	}
-	NumConfirmer = cli.UintFlag{
-		Name:     common.PrefixFlag(FlagPrefix, "num-confirmer"),
+	ConfirmerNumFlag = cli.UintFlag{
+		Name:     common.PrefixFlag(FlagPrefix, "confirmer-num"),
 		Usage:    "Number of confirmer go routines",
 		Required: false,
-		EnvVar:   common.PrefixEnvVar(envVarPrefix, "NUM_CONFIRMER"),
+		EnvVar:   common.PrefixEnvVar(envVarPrefix, "CONFIRMER_NUM"),
 		Value:    1,
 	}
 	// This flag is available so that we can manually adjust the number of chunks if desired for testing purposes or for other reasons.
@@ -155,6 +155,7 @@ var optionalFlags = []cli.Flag{
 	FinalizerIntervalFlag,
 	EncodingRequestQueueSizeFlag,
 	MaxNumRetriesPerBlobFlag,
+	ConfirmerNumFlag,
 	TargetNumChunksFlag,
 }
 

diff --git a/disperser/cmd/batcher/main.go b/disperser/cmd/batcher/main.go
@@ -107,7 +107,7 @@ func RunBatcher(ctx *cli.Context) error {
 	}
 
 	// confirmer
-	confirmer, err := batcher.NewConfirmer(config.EthClientConfig, config.StorageNodeConfig, queue, config.BatcherConfig.MaxNumRetriesPerBlob, config.BatcherConfig.NumConfirmer, logger, metrics)
+	confirmer, err := batcher.NewConfirmer(config.EthClientConfig, config.StorageNodeConfig, queue, config.BatcherConfig.MaxNumRetriesPerBlob, config.BatcherConfig.ConfirmerNum, logger, metrics)
 	if err != nil {
 		return err
 	}