Skip to content

Fix styles error in Home.css and deprecation warnings #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piglovesyou merged 2 commits into from
May 28, 2019
Merged

Fix styles error in Home.css and deprecation warnings #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef1cca
Fix styles error in Home.css
kutaloweb Apr 16, 2019
8d22ecb
Fix deprecation warnings
kutaloweb Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import React from 'react';
import ReactDOM from 'react-dom';
import deepForceUpdate from 'react-deep-force-update';
import queryString from 'query-string';
import { createPath } from 'history/PathUtils';
import { createPath } from 'history';
import App from './components/App';
import createFetch from './createFetch';
import history from './history';
Expand Down
2 changes: 1 addition & 1 deletion src/history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* LICENSE.txt file in the root directory of this source tree.
*/

import createBrowserHistory from 'history/createBrowserHistory';
import { createBrowserHistory } from 'history';

// Navigation manager, e.g. history.push('/home')
// https://github.com/mjackson/history
Expand Down
34 changes: 16 additions & 18 deletions src/routes/home/Home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,20 @@
font-size: 1.5rem;
}

.newsDesc {
h1,
h2,
h3,
h4,
h5,
h6 {
font-size: 1.125rem;
}

pre {
white-space: pre-wrap;
font-size: 0.875rem;
}

img {
max-width: 100%;
}
.newsDesc h1,
.newsDesc h2,
.newsDesc h3,
.newsDesc h4,
.newsDesc h5,
.newsDesc h6 {
font-size: 1.125rem;
}

.newsDesc pre {
white-space: pre-wrap;
font-size: 0.875rem;
}

.newsDesc img {
max-width: 100%;
Copy link
Collaborator

@langpavel langpavel May 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like slightly more the old version of this CSS file

Copy link
Collaborator

@piglovesyou piglovesyou May 10, 2019 •
edited by langpavel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the author of the PR doesn't notice

react-starter-kit/tools/postcss.config.js

Line 38 in 8d6c018

require('postcss-nesting')(),

But problem is CSS Nesting is far from standard. My idea to solve such postcss plugin matters is adopting postcss-preset-env, which allows us auto CSS compilation with the best manner, just like babel-preset-env. How about it?

}