-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features to feature/apollo-pure #1714
Merged
langpavel
merged 8 commits into
kriasoft:feature/apollo-pure
from
piglovesyou:feature/apollo-pure
Feb 19, 2019
Merged
Add features to feature/apollo-pure #1714
langpavel
merged 8 commits into
kriasoft:feature/apollo-pure
from
piglovesyou:feature/apollo-pure
Feb 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ncu --upgradeAll 4. Leave "graphql" to be "^13.2.0" that apollo packages depend on 2. Apply patch of "npx babel-upgrade" output 3. Leave only necessary babel plugins 4. Pass "yarn fix" by disabling stricter rules
* Through rootValue it cannot be passed from browser GraphQL access * rm unnecessary code
* rm unnecessary files
* npm graphql requires to be update vercel/next.js#5238 (comment)
* install apllo * add apollo.config.js * apollo codegen succeeded * fix: updateNetworkStatus signature * rm @flow from files not ready * add flow-typed files * done: Using auto-generated types works * flow-bin@0.89+ has regression. Use ^0.88.0. * fix: invalid GraphQL primitive types * Add codegen script * done: import auto-generated file * refac: move impl for apollo-link-state to graphql dir as same as server side resolvers * codegen and ignore eslint these files * refactor: "networkStatus" * feat: codegen:standalone
* delete existing auto-generated types * change script name * ignore __generated__ folder * wip: disallow absolute path resolving under `src` dir * It causes disregard .js type checking under src * fix all flow error * modify: prevent `withStyles` drops component type
* Fix build failure: Codegen before lint * Add Node v10 LTS for build target
@langpavel I enhanced Apollo integration. Glad if you take a look. |
Thank you! |
I thak you! But sorry, I must squash commits, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Apollo features.
Timestamp
scalar type