Skip to content

Commit

Permalink
Bug fix missing </form> tags
Browse files Browse the repository at this point in the history
  • Loading branch information
drlippman committed Mar 24, 2018
1 parent 8f2e1e0 commit 07ff124
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 7 deletions.
1 change: 1 addition & 0 deletions assessment/showtest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1793,6 +1793,7 @@
basicshowq($toshow);
showqinfobar($toshow,true,true,2);
echo '<input type="submit" class="btn" value="', _('Continue'), '" />';
echo '</form>';
} else { //are all done
$shown = showscores($questions,$attempts,$testsettings);
endtest($testsettings);
Expand Down
2 changes: 1 addition & 1 deletion course/addassessment.php
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,7 @@ function apwshowhide(s) {
</div>
</fieldset>
<div class=submit><input type=submit value="<?php echo $savetitle;?>"></div>

</form>
<?php
}
require("../footer.php");
Expand Down
2 changes: 1 addition & 1 deletion course/chgassessments.php
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ function valform() {
</table>
</fieldset>
<div class=submit><input type=submit value="<?php echo _('Apply Changes')?>"></div>

</form>
<?php
}
require("../footer.php");
Expand Down
1 change: 1 addition & 0 deletions course/chgblocks.php
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ function init() {
</tbody>
</table>
<div class=submit><input type=submit value="<?php echo _('Apply Changes')?>"></div>
</form>
<?php
}
require("../footer.php");
Expand Down
1 change: 1 addition & 0 deletions course/deleteblock.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
<input type=radio name="delcontents" value="1" checked="checked"/>Also Delete all items in block</p>
<p><button type=submit name="remove" value="really">Yes, Delete</button>
<input type=button value="Nevermind" class="secondarybtn" onClick="window.location='course.php?cid=<?php echo Sanitize::courseId($_GET['cid']); ?>'"></p>
</form>
<?php
}

Expand Down
1 change: 1 addition & 0 deletions course/modquestion.php
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ function previewq(qn) {
echo '</div>';
}
echo '<div class="submit"><input type="submit" value="'._('Save Settings').'"></div>';
echo '</form>';
}

require("../footer.php");
Expand Down
1 change: 1 addition & 0 deletions course/printtest.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
echo "<p>When you press Continue, your print-ready version of the test will display. You may wish to go into the File menu of ";
echo "your browser and select Page Setup to change the default headers and footers printed by your browser</p>\n";
echo "<p><input type=submit value=\"Continue\"></p>\n";
echo '</form>';
}
}

Expand Down
1 change: 1 addition & 0 deletions embedq.php
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ function sendresizemsg() {
echo " <input type=submit name=\"next\" value=\"" . _('New Question') . "\"/>\n";
}
echo '</p>';
echo '</form>';
/*
if ($showans) {
echo "<form id=\"qform\" method=\"post\" enctype=\"multipart/form-data\" action=\"" . Sanitize::encodeStringForDisplay($page_formAction) . "\" onsubmit=\"doonsubmit()\">\n";
Expand Down
13 changes: 9 additions & 4 deletions forms.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@

showNewUserValidation("pageform",array("oldpw"));

echo "<div class=submit><input type=submit value=Submit></div></form>\n";
echo "<div class=submit><input type=submit value=Submit></div>";
echo "</form>\n";
break;
case "chguserinfo":
//DB $query = "SELECT * FROM imas_users WHERE id='$userid'";
Expand Down Expand Up @@ -347,7 +348,8 @@
invalidHandler: function() {setTimeout(function(){$("#pageform").removeClass("submitted").removeClass("submitted2");}, 100)}}
);
</script>';
echo '<div class=submit><input type=submit value="Sign Up"></div></form>';
echo '<div class=submit><input type=submit value="Sign Up"></div>';
echo '</form>';
break;
case "unenroll":
if (!isset($_GET['cid'])) { echo "Course ID not specified\n"; break;}
Expand All @@ -360,6 +362,7 @@
echo '<form method="post" action="actions.php?cid='.Sanitize::courseId($_GET['cid']).'">';
echo '<p><button name="action" value="unenroll">'._('Really Unenroll').'</button>';
echo "<input type=button value=\"Nevermind\" class=\"secondarybtn\" onclick=\"window.location='./course/course.php?cid=".Sanitize::courseId($_GET['cid'])."'\"></p>\n";
echo '</form>';
break;
case "resetpw":
if ($gb == '') {
Expand Down Expand Up @@ -395,7 +398,8 @@
invalidHandler: function() {setTimeout(function(){$("#pageform").removeClass("submitted").removeClass("submitted2");}, 100)}}
);
</script>';
echo "<p><input type=submit value=\"Submit\" /></p></form>";
echo "<p><input type=submit value=\"Submit\" /></p>";
echo "</form>";
}

break;
Expand All @@ -415,7 +419,8 @@
invalidHandler: function() {setTimeout(function(){$("#pageform").removeClass("submitted").removeClass("submitted2");}, 100)}}
);
</script>';
echo "<p><input type=submit value=\"Submit\" /></p></form>";
echo "<p><input type=submit value=\"Submit\" /></p>";
echo "</form>";
break;
case "forumwidgetsettings":
//DB $query = "SELECT hideonpostswidget FROM imas_users WHERE id='$userid'";
Expand Down
1 change: 1 addition & 0 deletions util/blocksearch.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function getstr($items,$str,$parent) {
require("../header.php");
//DB echo '<form method="post"><p>Search: <input type="text" name="search" size="40" value="'.htmlentities(stripslashes($_POST['search'])).'"> <input type="submit" value="Search"/></p>';
echo '<form method="post"><p>Search: <input type="text" name="search" size="40" value="'.htmlentities($_POST['search']).'"> <input type="submit" value="Search"/></p>';
echo '</form>';
if (isset($_POST['search'])) {
echo '<p>';
$srch = $_POST['search'];
Expand Down
1 change: 1 addition & 0 deletions util/mergescores.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@
}
echo '</p>';
echo '<p><input type="submit" value="Submit"/></p>';
echo '</form>';
}
require("../footer.php");

Expand Down
5 changes: 4 additions & 1 deletion util/utils.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
echo '<input type=hidden name=action value="emulateuser" />';
echo 'Emulate user with userid: <input type="text" size="5" name="uid"/>';
echo '<input type="submit" value="Go"/>';
echo '</form>';
require("../footer.php");
} else if ($_GET['form']=='jumptoitem') {
require("../header.php");
Expand All @@ -93,6 +94,7 @@
echo 'Preview Question ID: <input type="text" size="8" name="pqid"/><br/>';
echo 'Edit Question ID: <input type="text" size="8" name="eqid"/><br/>';
echo '<input type="submit" value="Go"/>';
echo '</form>';
require("../footer.php");

} else if ($_GET['form']=='rescue') {
Expand All @@ -101,6 +103,7 @@
echo '<form method="post" action="'.$imasroot.'/util/rescuecourse.php">';
echo 'Recover lost items in course ID: <input type="text" size="5" name="cid"/>';
echo '<input type="submit" value="Go"/>';
echo '</form>';
require("../footer.php");
} else if ($_GET['form']=='lookup') {
require("../header.php");
Expand Down Expand Up @@ -238,7 +241,7 @@
echo '<form method="post" action="utils.php?form=lookup">';
echo 'Look up user: LastName: <input type="text" name="LastName" />, FirstName: <input type="text" name="FirstName" />, or username: <input type="text" name="SID"/>, or email: <input type="text" name="email"/>';
echo '<input type="submit" value="Go"/>';

echo '</form>';
}
require("../footer.php");

Expand Down
3 changes: 3 additions & 0 deletions wikis/viewwiki.php
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@
echo '<p><button type=submit name=delall value=true>'._("Yes, I'm Sure").'</button> ';
echo "<button type=\"button\" class=\"secondarybtn\" onclick=\"window.location.href='viewwiki.php?$querystring$framed'\">Nevermind</button></p>";
echo '</p>';
echo '</form>';

} else if (isset($_GET['delrev']) && isset($teacherid)) {
echo '<p>Are you SURE you want to delete all revision history for '.Sanitize::encodeStringForDisplay($grpnote).' Wiki page? The current version will be retained.</p>';
Expand All @@ -335,6 +336,7 @@
echo '<p><button type=submit name=delrev value=true>'._("Yes, I'm Sure").'</button> ';
echo "<button type=\"button\" class=\"secondarybtn\" onclick=\"window.location.href='viewwiki.php?$querystring$framed'\">Nevermind</button></p>";
echo '</p>';
echo '</form>';

} else if (isset($_GET['revert'])) {
$torev = Sanitize::onlyInt($_GET['torev']);
Expand All @@ -346,6 +348,7 @@
echo '<p><button type=submit name=revert value=true>'._("Yes, I'm Sure").'</button> ';
echo "<button type=\"button\" class=\"secondarybtn\" onclick=\"window.location.href='viewwiki.php?$querystring$framed'\">Nevermind</button></p>";
echo '</p>';
echo '</form>';

} else if (isset($_GET['snapshot'])) {
echo "<p>Current Version Code. <a href=\"viewwiki.php?cid=".Sanitize::courseId($cid)."&id=". Sanitize::onlyInt($id)."&grp=".Sanitize::onlyInt($groupid).Sanitize::encodeStringForDisplay($framed)."\">Back</a></p>";
Expand Down

0 comments on commit 07ff124

Please sign in to comment.