Skip to content

Update Solid v0.13.0 (and KO JSX, MobX JSX) #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Update Solid v0.13.0 (and KO JSX, MobX JSX) #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions frameworks/keyed/ko-jsx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
{
"name": "js-framework-benchmark-ko-jsx",
"version": "0.8.1",
"main": "index.js",
"js-framework-benchmark": {
"frameworkVersionFromPackage": "ko-jsx"
},
"scripts": {
"build-dev": "rollup -c",
"build-prod": "rollup -c --environment production"
},
"author": "Ryan Carniato",
"license": "Apache-2.0",
"homepage": "https://github.com/krausest/js-framework-benchmark",
"repository": {
"type": "git",
"url": "https://github.com/krausest/js-framework-benchmark.git"
},
"dependencies": {
"babel-plugin-jsx-dom-expressions": "0.11.2",
"knockout": "3.5.0",
"ko-jsx": "0.8.1"
},
"devDependencies": {
"@babel/core": "7.5.5",
"rollup": "1.17.0",
"rollup-plugin-babel": "4.3.3",
"rollup-plugin-commonjs": "9.2.0",
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-terser": "5.1.1"
}
}
{
"name": "js-framework-benchmark-ko-jsx",
"version": "0.10.0",
"main": "index.js",
"js-framework-benchmark": {
"frameworkVersionFromPackage": "ko-jsx"
},
"scripts": {
"build-dev": "rollup -c",
"build-prod": "rollup -c --environment production"
},
"author": "Ryan Carniato",
"license": "Apache-2.0",
"homepage": "https://github.com/krausest/js-framework-benchmark",
"repository": {
"type": "git",
"url": "https://github.com/krausest/js-framework-benchmark.git"
},
"dependencies": {
"babel-plugin-jsx-dom-expressions": "0.14.0",
"knockout": "3.5.0",
"ko-jsx": "0.10.0"
},
"devDependencies": {
"@babel/core": "7.6.4",
"rollup": "1.26.0",
"rollup-plugin-babel": "4.3.3",
"rollup-plugin-commonjs": "9.2.0",
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-terser": "5.1.2"
}
}
90 changes: 47 additions & 43 deletions frameworks/keyed/ko-jsx/src/template.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,48 @@
import { computed } from 'knockout';

const Button = ({id, text, fn}) =>
<div class='col-sm-6 smallpad'>
<button id={id} class='btn btn-primary btn-block' type='button' onClick={fn}>{text}</button>
</div>

const selectRow = (selected, rows) => {
let tr;
const cached = computed(rows);
computed(() => {
const s = selected();
if (tr) tr.className = '';
if (tr = s && cached().find(tr => tr.model === s)) tr.className = 'danger';
});
return cached;
}

export default function({data, selected, run, runLots, add, update, clear, swapRows, remove, select}) {
return <div class='container'>
<div class='jumbotron'><div class='row'>
<div class='col-md-6'><h1>KnockoutJSX-keyed</h1></div>
<div class='col-md-6'><div class='row'>
<Button id='run' text='Create 1,000 rows' fn={run} />
<Button id='runlots' text='Create 10,000 rows' fn={runLots} />
<Button id='add' text='Append 1,000 rows' fn={add} />
<Button id='update' text='Update every 10th row' fn={update} />
<Button id='clear' text='Clear' fn={clear} />
<Button id='swaprows' text='Swap Rows' fn={swapRows} />
</div></div>
</div></div>
<table class='table table-hover table-striped test-data'><tbody>{
selectRow(selected, data.memoMap(row =>
<tr model={row.id}>
<td class='col-md-1' textContent={row.id} />
<td class='col-md-4'><a onClick={select}>{row.label}</a></td>
<td class='col-md-1'><a onClick={remove}><span class='glyphicon glyphicon-remove' aria-hidden='true' /></a></td>
<td class='col-md-6'/>
</tr>
))
}</tbody></table>
<span class='preloadicon glyphicon glyphicon-remove' aria-hidden="true" />
</div>
import { computed } from 'knockout';

const Button = ({id, text, fn}) =>
<div class='col-sm-6 smallpad'>
<button id={id} class='btn btn-primary btn-block' type='button' onClick={fn}>{text}</button>
</div>

const selectRow = (selected, rows) => {
let tr;
const cached = computed(rows);
computed(() => {
const s = selected();
if (tr) tr.className = '';
if (tr = s && cached().find(tr => tr.model === s)) tr.className = 'danger';
});
return cached;
}

export default function({data, selected, run, runLots, add, update, clear, swapRows, remove, select}) {
let rowId;
const items = selectRow(selected, data.memoMap(row => (
rowId = row.id,
<tr model={rowId}>
<td class='col-md-1' textContent={rowId} />
<td class='col-md-4'><a onClick={select} textContent={row.label()} /></td>
<td class='col-md-1'><a onClick={remove}><span class='glyphicon glyphicon-remove' aria-hidden='true' /></a></td>
<td class='col-md-6'/>
</tr>
)));

return <div class='container'>
<div class='jumbotron'><div class='row'>
<div class='col-md-6'><h1>KnockoutJSX-keyed</h1></div>
<div class='col-md-6'><div class='row'>
<Button id='run' text='Create 1,000 rows' fn={run} />
<Button id='runlots' text='Create 10,000 rows' fn={runLots} />
<Button id='add' text='Append 1,000 rows' fn={add} />
<Button id='update' text='Update every 10th row' fn={update} />
<Button id='clear' text='Clear' fn={clear} />
<Button id='swaprows' text='Swap Rows' fn={swapRows} />
</div></div>
</div></div>
<table class='table table-hover table-striped test-data'><tbody>{
items
}</tbody></table>
<span class='preloadicon glyphicon glyphicon-remove' aria-hidden="true" />
</div>
}
68 changes: 34 additions & 34 deletions frameworks/keyed/mobx-jsx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
{
"name": "js-framework-benchmark-mobx-jsx",
"version": "0.6.3",
"main": "dist/main.js",
"js-framework-benchmark": {
"frameworkVersionFromPackage": "mobx-jsx"
},
"scripts": {
"build-dev": "rollup -c",
"build-prod": "rollup -c --environment production"
},
"author": "Ryan Carniato",
"license": "Apache-2.0",
"homepage": "https://github.com/krausest/js-framework-benchmark",
"repository": {
"type": "git",
"url": "https://github.com/krausest/js-framework-benchmark.git"
},
"dependencies": {
"babel-plugin-jsx-dom-expressions": "0.11.2",
"mobx": "5.13.0",
"mobx-jsx": "0.6.3"
},
"devDependencies": {
"@babel/core": "7.5.5",
"@babel/plugin-proposal-decorators": "7.4.4",
"@babel/plugin-proposal-class-properties": "7.5.5",
"rollup": "1.17.0",
"rollup-plugin-babel": "4.3.2",
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-replace": "^2.2.0",
"rollup-plugin-terser": "5.1.1"
}
}
{
"name": "js-framework-benchmark-mobx-jsx",
"version": "0.8.0",
"main": "dist/main.js",
"js-framework-benchmark": {
"frameworkVersionFromPackage": "mobx-jsx"
},
"scripts": {
"build-dev": "rollup -c",
"build-prod": "rollup -c --environment production"
},
"author": "Ryan Carniato",
"license": "Apache-2.0",
"homepage": "https://github.com/krausest/js-framework-benchmark",
"repository": {
"type": "git",
"url": "https://github.com/krausest/js-framework-benchmark.git"
},
"dependencies": {
"babel-plugin-jsx-dom-expressions": "0.14.0",
"mobx": "5.13.0",
"mobx-jsx": "0.8.0"
},
"devDependencies": {
"@babel/core": "7.6.4",
"@babel/plugin-proposal-decorators": "7.6.0",
"@babel/plugin-proposal-class-properties": "7.5.5",
"rollup": "1.26.0",
"rollup-plugin-babel": "4.3.3",
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-replace": "^2.2.0",
"rollup-plugin-terser": "5.1.2"
}
}
Loading