Adds riot-v3.0.7 #105
Adds riot-v3.0.7 #105
Conversation
|
Thx for adding the benchmark for riot 3. The steps I followed are: |
riot-v3.0.5/src/app.html
Outdated
| // we need to replace the id of this DOM element | ||
| // riot automatically bind ids to the tags scopes but 'update' is a read only property | ||
| // that's a quick way to replace the id in order to fit the bench specs | ||
| this._update.setAttribute('id', 'update') |
There was a problem hiding this comment.
this is no longer needed
riot-v3.0.5/webpack.config.js
Outdated
| { | ||
| test: /\.html$/, loader: 'tag', | ||
| query: { | ||
| type: 'babel' |
There was a problem hiding this comment.
change babel to es6
riot-v3.0.5/src/app.html
Outdated
| this.rows = store.data | ||
| this.selected = store.selected | ||
|
|
||
| this.one('mount', () => { |
There was a problem hiding this comment.
remove this listener
@PascalLeMerrer no problem, my pleasure! The change from babel -> es6 seems to have fixed this, pushed the change. |
riot-v3.0.5/src/app.html
Outdated
| </button> | ||
| </div> | ||
| <div class='col-sm-6 smallpad'> | ||
| <button type='button' class='btn btn-primary btn-block' id='_update' onclick={ methods.update }>Update every 10th row |
There was a problem hiding this comment.
change _update with update
|
@ckcollab It's still broken, by another error: |
|
@PascalLeMerrer hmm, this is what I get running the command you mentioned previously:
|
|
Sorry, I was not clear. The build works indeed, this error occurs later, when I try to run the benchmark in a web browser. Steps to reproduce:
It should display the test runner, instead I've got a blank page and the error message in the console. By the way, the page at http://127.0.0.1 misses a link to the test of Riot 3.0.5 |
|
@PascalLeMerrer @ckcollab hold on merging this. I will make a new patch release to fix the interop export issues soon |
|
@PascalLeMerrer added link from main page to riot 3.0.5, thanks for pointing that out. Can't wait to see what @GianlucaGuarini is cookin up 👍 |
|
@PascalLeMerrer you can now update and merge it should be fine |
|
@ckcollab did you run the tests? |
|
@PascalLeMerrer Yeah I get errors now, may have changed something unintentionally but does not seem to be working any more: $ npm run selenium -- --framework riot-v3
> webdriver-ts@1.0.0 selenium /Users/eric/src/js-framework-benchmark/webdriver-ts
> node dist/benchmarkRunner.js "--framework" "riot-v3"
{ _:
[ '/usr/local/bin/node',
'/Users/eric/src/js-framework-benchmark/webdriver-ts/dist/benchmarkRunner.js' ],
help: false,
framework: [ 'riot-v3' ],
check: 'false',
'$0': 'dist/benchmarkRunner.js' }
target directory results
Frameworks that will be benchmarked [ { name: 'riot-v3.0.7', uri: 'riot-v3.0.7', useShadowRoot: false } ]
Benchmarks that will be run [ '01_run1k',
'02_replace1k',
'03_update10th1k',
'04_select1k',
'05_swap1k',
'06_remove-one-1k',
'07_create10k',
'08_create1k-after10k',
'09_clear10k',
'10_clear-2nd-time10k',
'21_ready-memory',
'22_run-memory' ]
benchmarking { name: 'riot-v3.0.7', uri: 'riot-v3.0.7', useShadowRoot: false } 01_run1k
(node:9484) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
after initialized 01_run1k 0 riot-v3.0.7
retry failed
retry failed
retry failed
retry failed
retry failed
retry failed
QUIT
/Users/eric/src/js-framework-benchmark/webdriver-ts/node_modules/selenium-webdriver/lib/promise.js:654
throw error;
^
Retrying failed
|
|
I have the exact same issue, whatever the test I run is (not limited to riot-v3) |
|
Thanks for your work. Runs fine on my machine. Riot 3.0.7 performs much better than 2.6.7 in this benchmark: |
|
@krausest: yes I did. |
4 participants
Tested locally and seems to work! I'm going to run all results and make sure that works as well, will just take quite a while.
Resolves #85 and relates to riot/riot#1978 and riot/riot#2192