Update external libraries to Eclipse Mars 4.5

[markiewb]

Eclipse Mars 4.5 has been released. Could you update the plugin to use the new jar files from the 4.5 distribution?!

[markiewb]

I couldn't get the correct combination of jars to update it in my https://github.com/markiewb/eclipsecodeformatter_for_netbeans plugin.
-> Nevermind: Now it is working. I had to add core.runtime as lib and I had to fake a LogFilter interface. funfried/externalcodeformatter_for_netbeans#63

[dkornishev]

Sadly Mars code formatter is...different. Will there be an option for using formatter from 4.5?

[krasa]

What is the problem? The only thing different seems to be that org.eclipse.jdt.internal.formatter.DefaultCodeFormatter needs a Map in constructor, not Properties.​

[dkornishev]

The problem is that code formatter in 4.5 actually formats differently than code formatter in 4.4. See
http://eclipse-n-mati.blogspot.com/2015/06/eclipse-mars-how-to-switch-back-to.html for more details.

I don't know what the solution is (new version? bundle both formatters and provide an option?).

[krasa]

damn, I just pushed new libs :-)

We could bundle both versions and use a custom classloader to avoid conflicts.

[krasa]

Actually we could bundle that old formatter eclipse plugin, that's easy.

[dkornishev]

Will there be a new version of plugin soon, or will I need to build/install manually?

[krasa]

Build manually.

Not sure when I will have time to bundle that old formatter.

[dkornishev]

I need the new formatter though.
So clone the project and build with intellij plugin builder?

[krasa]

yep

[dkornishev]

Instructions? I imported the project but it doesn't even compile. I ran dependency downloader pom and it looks like it fetched stuff but it didn't fix it

[krasa]

you need to configure IntelliJ SDK - https://www.jetbrains.com/idea/help/configuring-intellij-platform-plugin-sdk.html - create new Intellij Platform SDK (just like with Java JDK, and select your installed IntelliJ)

all jars are commited, I just pushed fixed module config, so it should work out of box, otherwise just add those jars as libraries.

it should look like this: