Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing container to component prop helper functions #382

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Support passing container to component prop helper functions #382

merged 3 commits into from
Dec 7, 2021

Conversation

bluepnume
Copy link
Collaborator

@bluepnume bluepnume commented Dec 2, 2021 •
edited
Loading

@bluepnume bluepnume requested a review from a team as a code owner December 2, 2021 22:12
@bluepnume bluepnume force-pushed the multi-props branch 4 times, most recently from d5ad10e to 7bf8d3d Compare December 6, 2021 20:54
westeezy
westeezy approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@westeezy westeezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. caveat is that i don't feel intimately familiar with zoid just yet, but everything here seems good. let me know if i can help with any manual testing or integration testing if needed

@bluepnume
Copy link
Collaborator Author

Thanks folks. Gonna merge and publish this now.

@bluepnume bluepnume merged commit 2c3aac7 into master Dec 7, 2021
westeezy added a commit that referenced this pull request Dec 9, 2021
@westeezy
Revert "Support passing container to component prop helper functions (#…
9ec9105 
…382)"

This reverts commit 2c3aac7.
bluepnume added a commit that referenced this pull request Dec 13, 2021
@bluepnume
Revert "Support passing container to component prop helper functions (#…
4fba82c 
…382)"

This reverts commit 2c3aac7.
bluepnume pushed a commit that referenced this pull request Dec 14, 2021
@bluepnume
Support passing container to component prop helper functions (#382)
7ac27f5 
* Pass container to prop definitions when available (#376)

* Avoid re-decorating the same prop multiple times

* Only use node 14 for github ci
bluepnume pushed a commit that referenced this pull request Dec 14, 2021
@bluepnume
Support passing container to component prop helper functions (#382)
745df0e 
* Pass container to prop definitions when available (#376)

* Avoid re-decorating the same prop multiple times

* Only use node 14 for github ci
bluepnume pushed a commit that referenced this pull request Dec 14, 2021
@bluepnume
Support passing container to component prop helper functions (#382)
f9c8cad 
* Pass container to prop definitions when available (#376)

* Avoid re-decorating the same prop multiple times

* Only use node 14 for github ci
bluepnume pushed a commit that referenced this pull request Jan 12, 2022
@bluepnume
Support passing container to component prop helper functions (#382)
79f39b4 
* Pass container to prop definitions when available (#376)

* Avoid re-decorating the same prop multiple times

* Only use node 14 for github ci
bluepnume pushed a commit that referenced this pull request Jan 12, 2022
Support passing container to component prop helper functions (#382) (#…
29be230 
…384)

* Pass container to prop definitions when available (#376)

* Avoid re-decorating the same prop multiple times

* Only use node 14 for github ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westeezy westeezy westeezy approved these changes

@gregjopa gregjopa gregjopa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluepnume @gregjopa @westeezy