fix: specify dimensions in iframe demo #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you go to https://krakenjs.com/zoid/demo/basic/iframe/index.htm, you'll see that the iframe login is missing.
This is because the dimensions aren't being passed, so the height and width are being set to undefined.
Passing the dimensions fixes the issue:
A broader question I have is whether or not
dimensions
should be a required attribute or not. Currently, it's not marked as required in the docs: https://github.com/krakenjs/zoid/blob/master/docs/api/create.md#dimensions--width--string-height--string-