Modify API to be asynchronous #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // require.resolve will locate a file without a known extension (e.g. txt) | ||
| // and try to load it as javascript. That won't work for this case. | ||
| var ext = path.extname(file); | ||
| return ext === '' || require.extensions.hasOwnProperty(ext); |
There was a problem hiding this comment.
So this assumes an extensionless file should be required as though it's js, right? That strikes me as odd behavior.
Update: we chatted. Short answer: because node.
|
Looks good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-trivial rewrite that will be released as v1.0.0. Changes include:
resolveFileSyncresolveandresolveFilenow have the signaturefunction (data, errback)function (value, [errback])unuseworks properly.