Ensure types (specifically Buffer) are not lost across shortstop reso…

…lves
krakenjs · Jun 19, 2014 · 47b91f1 · 47b91f1
1 parent 3e07052
commit 47b91f1
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/resolver.js b/lib/resolver.js
@@ -141,7 +141,7 @@ exports.create = function create(parent) {
 
             self = this;
 
-            if (thing.isObject(data)) {
+            if (thing.isObject(data) && !Buffer.isBuffer(data)) {
 
                 if (thing.isArray(data)) {
                     tasks = data.map(function (val) {

diff --git a/test/index.js b/test/index.js
@@ -329,4 +329,31 @@ test('shortstop', function (t) {
     });
 
 
+    t.test('preserve buffers', function (t) {
+        var resolver;
+
+        function file(value, cb) {
+            require('fs').readFile(value, cb);
+        }
+
+        resolver = shortstop.create();
+        resolver.use('file', file);
+        resolver.resolve({ buffer: 'file:./index.js' }, function (err, data) {
+            t.error(err);
+            t.ok(data);
+            t.ok(data.buffer);
+            t.ok(Buffer.isBuffer(data.buffer));
+
+            resolver = shortstop.create();
+            resolver.resolve(data, function (err, data) {
+                t.error(err);
+                t.ok(data);
+                t.ok(data.buffer);
+                t.ok(Buffer.isBuffer(data.buffer));
+                t.end();
+            });
+        });
+    });
+
+
 });