replaced urlpush with sprintf to avoid beginning slash #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feedback:
|
This was referenced Dec 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When calling
.Diff()to compare two nodes, the extensions will contain a leading slash in their url (for example:<nodeid>:/type.googleapis.com/proto.blah/State). This is due to howURLPush()works. This will cause issues with the SME because it filters out any STATE_CHANGE events that contain extensions with a leading slash.Solution:
I replaced
URLPush()with sprintf to just append the extension url to the node id. I didn't do extensive testing on this, but it did fix the issue with the SME filtering out my events.