Use simplified solution from prometheus#1609 for the data race

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama · Sep 2, 2024 · dfbd8eb · dfbd8eb
1 parent 2686d12
commit dfbd8eb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/prometheus/histogram.go b/prometheus/histogram.go
@@ -1673,6 +1673,7 @@ func makeNativeExemplars(ttl time.Duration, maxCount int) nativeExemplars {
 
 	if maxCount < 0 {
 		maxCount = 0
+		ttl = -1
 	}
 
 	return nativeExemplars{
@@ -1682,13 +1683,13 @@ func makeNativeExemplars(ttl time.Duration, maxCount int) nativeExemplars {
 }
 
 func (n *nativeExemplars) addExemplar(e *dto.Exemplar) {
-	n.Lock()
-	defer n.Unlock()
-
-	if cap(n.exemplars) == 0 {
+	if n.ttl == -1 {
 		return
 	}
 
+	n.Lock()
+	defer n.Unlock()
+
 	// The index where to insert the new exemplar.
 	var nIdx int = -1