Skip to content

Conversation

@adalessandro
Copy link

@adalessandro adalessandro commented Oct 23, 2024

Links:
#1023
OSSystems/meta-browser#842


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
@adalessandro adalessandro requested a review from kraj as a code owner October 23, 2024 02:03
@adalessandro adalessandro marked this pull request as draft October 23, 2024 02:03
@adalessandro
Copy link
Author

adalessandro commented Oct 23, 2024

@kraj @MaxIhlenfeldt I've created this (still) work in progress PR so we can discuss on top of it:

I'd like your comments if possible:

  • Is it okay to just backport the specific clang recipes part?
  • The README and probably conf/nonclangable.conf files need to be updated as well. Could you help there perhaps?
  • Is there a testing/CI to be used here?

@adalessandro adalessandro changed the title WIP: Backport clang from scarthgap kirkstone: backport clang from scarthgap Oct 23, 2024
@adalessandro
Copy link
Author

* Is it okay to just backport the specific `clang` recipes part?

Regarding the above, definitely other parts in this layer (that depends on clang) need to be updated as well.

@MaxIhlenfeldt
Copy link
Contributor

Will defer to kraj as I'm not too familiar with meta-clang.

@adalessandro
Copy link
Author

@kraj whenever you have some time (I know you're busy :-) ) please give me some guidelines on how to follow up, then I can polish this up. Thanks!

@petermarko
Copy link
Contributor

This will not be accepted, LTS branches do not accept major version updates.
I wonder if this could be submitted to https://git.yoctoproject.org/meta-lts-mixins/ as new branch kirkstone/clang

@adalessandro
Copy link
Author

adalessandro commented Nov 1, 2024

This will not be accepted, LTS branches do not accept major version updates. I wonder if this could be submitted to https://git.yoctoproject.org/meta-lts-mixins/ as new branch kirkstone/clang

@petermarko thanks, you're right, so I'll close this one. Just in case, do you know who should I ask? AFAICS Scott scott.murray@konsulko.com is the maintainer, but I couldn't reach him yet.

@petermarko
Copy link
Contributor

Afaik each branch of mixin layers repo is maintained by someone else.
So you need to find someone willing to be the maintainer of kirkstone/clang branch or become the maintainer yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants