-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Datasets with loaders #430
base: main
Are you sure you want to change the base?
Conversation
f727c5b
to
53b7c8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 89.72% 90.62% +0.89%
==========================================
Files 62 77 +15
Lines 2444 2635 +191
==========================================
+ Hits 2193 2388 +195
+ Misses 251 247 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to make datasets easier to use and reuse with different datasets (not just ours)
Try to add tests to that and make it pass in ci/cd (you might need to wait on #438 as some issues will be resolved there) |
Note:
|
""" | ||
AirbnbMulticity dataset. | ||
|
||
Dataset description will be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add description
srai/loaders/hugging_face_loader.py
Outdated
Defaults to None. | ||
|
||
Returns: | ||
gpd.GeoDataFrame: _description_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that docs are added and example notebooks are generated there correctly.
Make hf datasets public and remove getting and setting the hf_tokens
in the notebooks. (dont remove the functionality of passing the hf_token in the datasets)
Make hf_token
and version
parameters in load() in reverse order - load(version, hf_token)
, not load(hf_token, version)
. Update all the docstrings and usages
for more information, see https://pre-commit.ci
No description provided.