feat: Datasets with loaders #430
Conversation
ofurman
force-pushed
the
obsrai
branch
2 times, most recently
from
f727c5b
to
53b7c8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 89.72% 90.62% +0.89%
==========================================
Files 62 77 +15
Lines 2444 2635 +191
==========================================
+ Hits 2193 2388 +195
+ Misses 251 247 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Try to add tests to that and make it pass in ci/cd (you might need to wait on #438 as some issues will be resolved there) |
|
Note:
|
| """ | ||
| AirbnbMulticity dataset. | ||
|
|
||
| Dataset description will be added. |
srai/loaders/hugging_face_loader.py
Outdated
| Defaults to None. | ||
|
|
||
| Returns: | ||
| gpd.GeoDataFrame: _description_ |
There was a problem hiding this comment.
Make sure that docs are added and example notebooks are generated there correctly.
Make hf datasets public and remove getting and setting the hf_tokens in the notebooks. (dont remove the functionality of passing the hf_token in the datasets)
Make hf_token and version parameters in load() in reverse order - load(version, hf_token), not load(hf_token, version). Update all the docstrings and usages
for more information, see https://pre-commit.ci
No description provided.