Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace logic in OsmPbfLoader from osmium to QuackOSM #405

Merged
merged 163 commits into from
Feb 2, 2024

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Nov 20, 2023

No description provided.

@RaczeQ RaczeQ changed the title feat: duckdb OSM PBF native reader feat: DuckDB OSM PBF native reader Nov 20, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dcc9344) 88.62% compared to head (98aa6b5) 89.68%.

Files Patch % Lines
srai/loaders/osm_loaders/osm_pbf_loader.py 84.00% 4 Missing ⚠️
srai/loaders/osm_loaders/filters/_typing.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   88.62%   89.68%   +1.05%     
==========================================
  Files          66       62       -4     
  Lines        2928     2414     -514     
==========================================
- Hits         2595     2165     -430     
+ Misses        333      249      -84     
Flag Coverage Δ
macos-latest-python3.11 89.68% <90.62%> (+1.57%) ⬆️
ubuntu-latest-python3.10 89.68% <90.62%> (+1.74%) ⬆️
ubuntu-latest-python3.11 89.68% <90.62%> (+1.67%) ⬆️
ubuntu-latest-python3.9 89.66% <90.62%> (+1.74%) ⬆️
windows-latest-python3.11 89.68% <90.62%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaczeQ RaczeQ marked this pull request as ready for review November 28, 2023 23:37
@RaczeQ RaczeQ changed the title feat: DuckDB OSM PBF native reader feat: replace logic in OsmPbfLoader from osium to QuackOSM Feb 1, 2024
@RaczeQ RaczeQ changed the title feat: replace logic in OsmPbfLoader from osium to QuackOSM feat: replace logic in OsmPbfLoader from osmium to QuackOSM Feb 1, 2024
piotrgramacki
piotrgramacki previously approved these changes Feb 2, 2024
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nicely done

@RaczeQ RaczeQ merged commit 93dc1ce into main Feb 2, 2024
10 checks passed
@RaczeQ RaczeQ deleted the duckdb_osm_native_reader branch February 2, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants