Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to clip osmpbf files with osmosis and osmconvert tools #370

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Oct 20, 2023

To speed up the OSM PBF parsing operations, osmconvert and osmosis CLI tools have been integrated to automatically clip big PBF files from the Geofabrik service and make it easier to be loaded into memory,.

@RaczeQ RaczeQ added enhancement New feature or request hacktoberfest-accepted This pull request is accepted in Hacktoberfest labels Oct 20, 2023
@RaczeQ RaczeQ linked an issue Oct 20, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (bc7ec3c) 88.57% compared to head (0fdc9a8) 88.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   88.57%   88.22%   -0.35%     
==========================================
  Files          61       62       +1     
  Lines        2407     2565     +158     
==========================================
+ Hits         2132     2263     +131     
- Misses        275      302      +27     
Flag Coverage Δ
macos-latest-python3.11 87.64% <74.28%> (-0.77%) ⬇️
ubuntu-latest-python3.10 87.52% <72.57%> (-0.81%) ⬇️
ubuntu-latest-python3.11 87.52% <72.57%> (-0.89%) ⬇️
ubuntu-latest-python3.8 87.50% <72.57%> (-0.89%) ⬇️
ubuntu-latest-python3.9 87.50% <72.57%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
srai/geometry.py 100.00% <100.00%> (ø)
srai/loaders/download.py 100.00% <100.00%> (+46.66%) ⬆️
srai/loaders/osm_loaders/osm_pbf_loader.py 93.02% <100.00%> (+0.16%) ⬆️
srai/loaders/osm_loaders/openstreetmap_extracts.py 57.89% <77.77%> (+2.08%) ⬆️
srai/loaders/osm_loaders/pbf_file_downloader.py 89.00% <70.00%> (-8.71%) ⬇️
srai/loaders/osm_loaders/pbf_file_clipper.py 85.59% <85.59%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaczeQ RaczeQ merged commit 0df59c3 into main Oct 21, 2023
10 checks passed
@RaczeQ RaczeQ deleted the 369-add-option-to-clip-osmpbf-files-with-osmosis-and-osmconvert-tools branch October 21, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted This pull request is accepted in Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to clip osm.pbf files with osmosis and osmconvert tools
2 participants