Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hex2Vec embedder #236

Merged
merged 21 commits into from
Apr 27, 2023
Merged

Conversation

simonusher
Copy link
Collaborator

No description provided.

@simonusher simonusher linked an issue Apr 24, 2023 that may be closed by this pull request
@Calychas Calychas force-pushed the 79-add-embedder-for-hex2vec-use-case branch from 1164f94 to 34c7d9e Compare April 24, 2023 21:10
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #236 (2283b18) into main (94a3a6b) will decrease coverage by 1.27%.
The diff coverage is 85.85%.

❗ Current head 2283b18 differs from pull request most recent head 6b8037e. Consider uploading reports for the commit 6b8037e to get more accurate results

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   97.54%   96.28%   -1.27%     
==========================================
  Files          55       60       +5     
  Lines        1632     1829     +197     
==========================================
+ Hits         1592     1761     +169     
- Misses         40       68      +28     
Flag Coverage Δ
macos-latest-python3.10 ?
ubuntu-latest-python3.10 96.28% <85.85%> (-1.21%) ⬇️
ubuntu-latest-python3.8 96.27% <85.85%> (-1.27%) ⬇️
ubuntu-latest-python3.9 96.27% <85.85%> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/utils/_pytorch_stubs.py 0.00% <0.00%> (ø)
srai/embedders/hex2vec/model.py 71.42% <71.42%> (ø)
srai/embedders/hex2vec/neighbour_dataset.py 96.49% <96.49%> (ø)
srai/embedders/hex2vec/embedder.py 96.66% <96.66%> (ø)
srai/embedders/__init__.py 100.00% <100.00%> (ø)
srai/embedders/count_embedder.py 100.00% <100.00%> (ø)
srai/embedders/hex2vec/__init__.py 100.00% <100.00%> (ø)

srai/embedders/hex2vec/embedder.py Outdated Show resolved Hide resolved
srai/embedders/hex2vec/embedder.py Outdated Show resolved Hide resolved
srai/embedders/hex2vec/neighbour_dataset.py Outdated Show resolved Hide resolved
piotrgramacki
piotrgramacki previously approved these changes Apr 26, 2023
…ransforming without fitting the model and using default encoder_sizes
piotrgramacki
piotrgramacki previously approved these changes Apr 26, 2023
RaczeQ
RaczeQ previously approved these changes Apr 26, 2023
Copy link
Collaborator

@RaczeQ RaczeQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like current variables naming. It's really clear to follow 🥇

@simonusher simonusher dismissed stale reviews from RaczeQ and piotrgramacki via baf58ad April 26, 2023 17:06
piotrgramacki
piotrgramacki previously approved these changes Apr 26, 2023
@Calychas
Copy link
Collaborator

Add an example with some clustering or other visualizations (RGB)

Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Hex2Vec to tests/miscellaneous/test_optional_dependencies.py -> test_torch()

tests/embedders/hex2vec/test_neighbour_dataset.py Outdated Show resolved Hide resolved
tests/embedders/hex2vec/test_neighbour_dataset.py Outdated Show resolved Hide resolved
srai/embedders/hex2vec/embedder.py Show resolved Hide resolved
piotrgramacki
piotrgramacki previously approved these changes Apr 27, 2023
@Calychas Calychas merged commit 3d77fb6 into main Apr 27, 2023
@Calychas Calychas deleted the 79-add-embedder-for-hex2vec-use-case branch April 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add embedder for hex2vec use case
4 participants