-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OSM Tile Loader #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks ;) I left some comments, mostly regarding some code standards.
Unfortunately, there is one error, which made it impossible for me to run this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mprzymus!
I'm nitpicking, but I see that commits are not following the conventional commit
message. I'm not sure if pre-commit ran correctly locally on your side.
Please refer to CONTRIBUTING.md
and install pre-commit correctlly. No need to fix the messages now (in the end they are irrelevant as the PR is squashed), but for future reference ;)
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
========================================
Coverage 97.54% 97.54%
========================================
Files 52 55 +3
Lines 1506 1632 +126
========================================
+ Hits 1469 1592 +123
- Misses 37 40 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job! I'm delighted that you could stick to the rest of the codebase style.
I've pointed out some things that irked me though.
The next good addition would be automatic stitching of the downloaded tiles and cropping them to the given region shape or at least the bounding box of it (some regionizer/feature generator?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, but overall outstanding work Marcin!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But wait for others before merging
Created loader which downloads tiles for specified area.