Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: torch and pytorch-lightning as optional dependencies #215

Merged
merged 19 commits into from
Apr 25, 2023
Merged

chore: torch and pytorch-lightning as optional dependencies #215

merged 19 commits into from
Apr 25, 2023

Conversation

Calychas
Copy link
Collaborator

Closes #210

@Calychas Calychas added the enhancement New feature or request label Mar 25, 2023
@Calychas Calychas self-assigned this Mar 25, 2023
@Calychas Calychas linked an issue Mar 25, 2023 that may be closed by this pull request
Move torch and pytorch-lightning packages to optional group #210
Closed
@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Merging #215 (3be56a8) into main (553179d) will decrease coverage by 0.25%.
The diff coverage is 89.18%.

❗ Current head 3be56a8 differs from pull request most recent head 127674d. Consider uploading reports for the commit 127674d to get more accurate results

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   97.79%   97.54%   -0.25%     
==========================================
  Files          52       52              
  Lines        1495     1506      +11     
==========================================
+ Hits         1462     1469       +7     
- Misses         33       37       +4
Flag Coverage Δ
macos-latest-python3.10 97.54% <89.18%> (-0.25%) ⬇️
ubuntu-latest-python3.10 97.47% <89.18%> (-0.25%) ⬇️
ubuntu-latest-python3.8 97.47% <89.18%> (-0.25%) ⬇️
ubuntu-latest-python3.9 97.47% <89.18%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/loaders/osm_loaders/pbf_file_downloader.py 96.66% <ø> (ø)
srai/neighbourhoods/_base.py 100.00% <ø> (ø)
srai/embedders/gtfs2vec/model.py 92.59% <83.33%> (-7.41%) ⬇️
srai/embedders/highway2vec/model.py 93.33% <86.66%> (-6.67%) ⬇️
srai/embedders/gtfs2vec/embedder.py 100.00% <100.00%> (ø)
srai/embedders/highway2vec/embedder.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Calychas Calychas force-pushed the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch from f5c25ed to 91e62dc Compare April 2, 2023 17:34
@Calychas Calychas force-pushed the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch 2 times, most recently from 251cc97 to d65f62b Compare April 24, 2023 19:10
@Calychas Calychas marked this pull request as ready for review April 24, 2023 20:41
@Calychas Calychas force-pushed the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch from 01089b3 to 047ab7a Compare April 24, 2023 21:08
piotrgramacki
piotrgramacki previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Calychas Calychas force-pushed the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch from 68a4f36 to 6427fc2 Compare April 25, 2023 15:57
@Calychas Calychas force-pushed the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch from 6ea4db5 to 7c131e6 Compare April 25, 2023 16:13
piotrgramacki
piotrgramacki previously approved these changes Apr 25, 2023
View reviewed changes
RaczeQ
RaczeQ reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@RaczeQ RaczeQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add info to Getting Started section about new optional group for installation.

@Calychas Calychas merged commit 2f64ece into main Apr 25, 2023
@Calychas Calychas deleted the 210-move-torch-and-pytorch-lightning-packages-to-optional-group branch April 25, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrgramacki piotrgramacki piotrgramacki approved these changes

@RaczeQ RaczeQ Awaiting requested review from RaczeQ

Assignees

@Calychas Calychas

@piotrgramacki piotrgramacki

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move torch and pytorch-lightning packages to optional group
3 participants
@Calychas @RaczeQ @piotrgramacki