Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic plotting functions to the library #204

Merged
merged 45 commits into from
Mar 29, 2023
Merged

feat: add basic plotting functions to the library #204

merged 45 commits into from
Mar 29, 2023

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Mar 14, 2023

No description provided.

@RaczeQ RaczeQ linked an issue Mar 14, 2023 that may be closed by this pull request
Add basic plotting functions to the library #200
Closed
@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Merging #204 (a2a1eea) into main (e962521) will increase coverage by 0.02%.
The diff coverage is 98.14%.

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   94.57%   94.60%   +0.02%     
==========================================
  Files          47       47              
  Lines        1365     1391      +26     
==========================================
+ Hits         1291     1316      +25     
- Misses         74       75       +1
Flag Coverage Δ
macos-latest-python3.10 94.60% <98.14%> (+0.02%) ⬆️
ubuntu-latest-python3.10 94.60% <98.14%> (+0.10%) ⬆️
ubuntu-latest-python3.8 94.52% <98.14%> (+0.03%) ⬆️
ubuntu-latest-python3.9 94.52% <98.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../regionizers/administrative_boundary_regionizer.py 96.06% <96.77%> (-0.06%) ⬇️
srai/embedders/_base.py 100.00% <100.00%> (ø)
srai/loaders/geoparquet_loader.py 100.00% <100.00%> (ø)
srai/loaders/gtfs_loader.py 100.00% <100.00%> (ø)
srai/loaders/osm_loaders/osm_online_loader.py 100.00% <100.00%> (ø)
srai/neighbourhoods/_base.py 100.00% <100.00%> (ø)
srai/neighbourhoods/adjacency_neighbourhood.py 100.00% <100.00%> (ø)
srai/regionizers/h3_regionizer.py 100.00% <100.00%> (ø)
srai/regionizers/s2_regionizer.py 100.00% <100.00%> (ø)
srai/regionizers/voronoi_regionizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RaczeQ
feat: add new test for AdministrativeBoundaryRegionizer
86350b7
@RaczeQ
feat: add new neighbourhood tests
8398cdb
@RaczeQ
feat: add new plotting functions
1a25012
@RaczeQ
Merge branch 'main' into 200-add-basic-plotting-functions-to-the-library
32116b3
@RaczeQ
feat: add new dependencies section
b8fac5c
@RaczeQ
chore: add new flags to isort
cfa3b4b
@RaczeQ
chore: modify test notebook
961faf1
@RaczeQ
ci: exclude plotting module from coverage
67e355e
@RaczeQ
chore: merge remote-tracking branch 'origin/main' into 200-add-basic-…
acfb825 
…plotting-functions-to-the-library
@RaczeQ
feat: added plotly and folium functions
5c6aa7b
@RaczeQ
feat: added parameter to folium plots
8c4e2d2
@RaczeQ
feat: modified folium colourscales
67ac2f6
@RaczeQ
feat: modify voronoi regionizer notebook
eb6175b
@RaczeQ
feat: modified regionizers notebooks
aa69da3
@RaczeQ
feat: added adjacency neighbourhood example
0e770e3
@RaczeQ
Merge branch 'main' into 200-add-basic-plotting-functions-to-the-library
4c874ae
@RaczeQ
chore: change pdm lock file
82e7973
@RaczeQ
fix(AdministrativeBoundaryRegionizer): clipping
19afefb 
* changed filtering based on points
@RaczeQ
fix: changes points and polygons clipping
0ed62a5
@RaczeQ
chore: changed docstrings
17a1116
@RaczeQ RaczeQ marked this pull request as ready for review March 23, 2023 18:11
Calychas
Calychas requested changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @RaczeQ. Great changes that improve docs by a lot. Really got me thinking of actually patching in the plotting functions directly into GeoDataFrame ;p

srai/regionizers/administrative_boundary_regionizer.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
srai/plotting/folium_wrapper.py Outdated Show resolved Hide resolved
srai/plotting/folium_wrapper.py Outdated Show resolved Hide resolved
srai/plotting/folium_wrapper.py Outdated Show resolved Hide resolved
piotrgramacki
piotrgramacki reviewed Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here!

srai/regionizers/administrative_boundary_regionizer.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
srai/plotting/plotly_wrapper.py Show resolved Hide resolved
@RaczeQ RaczeQ requested a review from Calychas March 29, 2023 08:07
Calychas
Calychas approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RaczeQ RaczeQ merged commit 48cbb27 into main Mar 29, 2023
@RaczeQ RaczeQ deleted the 200-add-basic-plotting-functions-to-the-library branch March 29, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calychas Calychas Calychas approved these changes

@piotrgramacki piotrgramacki piotrgramacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic plotting functions to the library
3 participants
@RaczeQ @Calychas @piotrgramacki