Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: h3 regionizer very slow with buffer=True and large number of regions #194

Conversation

simonusher
Copy link
Collaborator

No description provided.

@simonusher simonusher linked an issue Mar 5, 2023 that may be closed by this pull request
@simonusher simonusher requested review from RaczeQ and Calychas and removed request for RaczeQ March 5, 2023 23:06
RaczeQ
RaczeQ previously approved these changes Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #194 (150c223) into main (ef3672c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          33       33           
  Lines         791      794    +3     
=======================================
+ Hits          785      788    +3     
  Misses          6        6           
Flag Coverage Δ
macos-latest-python3.10 99.24% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.10 99.11% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.8 99.11% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.9 99.24% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/regionizers/h3_regionizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonusher simonusher force-pushed the 193-h3regionizer-very-slow-with-large-number-of-regions-and-buffer=true branch from 5874e68 to b5ae7ae Compare March 8, 2023 20:43
@simonusher simonusher requested a review from RaczeQ March 8, 2023 21:05
@simonusher simonusher merged commit 4da1270 into main Mar 9, 2023
@simonusher simonusher deleted the 193-h3regionizer-very-slow-with-large-number-of-regions-and-buffer=true branch March 9, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H3Regionizer very slow with large number of regions and buffer=True
4 participants