Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

109-validate-licenses-of-used-libraries-and-tools #164

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Jan 20, 2023

  • Add an automatic license checker package for new libraries to avoid legal problems.
  • Add a pre-commit step for CI to run it.
  • Add package configuration to the project.toml file.
  • Remove all packages used currently that have an unmatching license.

@RaczeQ RaczeQ linked an issue Jan 20, 2023 that may be closed by this pull request
@RaczeQ
Copy link
Collaborator Author

RaczeQ commented Jan 20, 2023

Blocked by this PR on the required package: FHPythonUtils/LicenseCheck#29

@RaczeQ RaczeQ added the enhancement New feature or request label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #164 (dafb5c7) into main (23ae7c7) will increase coverage by 0.20%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   98.75%   98.96%   +0.20%     
==========================================
  Files          20       20              
  Lines         483      481       -2     
==========================================
- Hits          477      476       -1     
+ Misses          6        5       -1     
Flag Coverage Δ
macos-latest-python3.11 98.96% <89.47%> (+0.20%) ⬆️
ubuntu-latest-python3.10 98.75% <89.47%> (+0.82%) ⬆️
ubuntu-latest-python3.11 98.75% <89.47%> (+0.82%) ⬆️
ubuntu-latest-python3.8 98.75% <89.47%> (+0.82%) ⬆️
ubuntu-latest-python3.9 98.75% <89.47%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../regionizers/administrative_boundary_regionizer.py 95.14% <89.47%> (+0.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RaczeQ RaczeQ marked this pull request as ready for review February 9, 2023 10:22
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Are we going to worry about those codecov problems?

@RaczeQ RaczeQ merged commit f766137 into main Feb 9, 2023
@RaczeQ RaczeQ deleted the 109-validate-licenses-of-used-libraries-and-tools branch February 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate licenses of used libraries and tools
2 participants