Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin code for computational complexity #1090

Merged
merged 19 commits into from
Feb 27, 2024
Merged

Add Kotlin code for computational complexity #1090

merged 19 commits into from
Feb 27, 2024

Conversation

curtishd
Copy link
Contributor

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.
    Here is the output:
    屏幕截图 2024-02-21 084900
    屏幕截图 2024-02-21 084911
    屏幕截图 2024-02-21 084942
    屏幕截图 2024-02-21 085000
    屏幕截图 2024-02-21 085015

* Author: curtishd (1023632660@qq.com)
*/

package chapter_computational_complexity.iteration
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the iteration folder to make the relative path consistent with it in other programming languages?

codes/kotlin/chapter_computational_complexity/iteration/iteration.kt -> codes/kotlin/chapter_computational_complexity/iteration.kt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you make the same modification on the backtracking chapter? Thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I am not sure which part of chapter backtracking should be modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry did i miss something?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry did i miss something?

The package name should be chapter_computational_complexity.iteration

You need to make the same modification(move them out of the subfolders) to all the code files in the computational complexity chapter and backtracking chapter.

Please carefully check all the changes and the latest file status in https://github.com/krahets/hello-algo/pull/1090/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make all changes this time. Please take a look.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Have you tested all the code and ensure they're runnable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the code of all files are work well.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@krahets krahets added the code Code-related label Feb 27, 2024
@krahets krahets merged commit 306dc01 into krahets:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants