Open
Conversation
…adaptive retry logic to avoid hang forever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose grpc cancel error to etcd client to avoid client hang forever
Relative issue refer to #1227
Main modify in watch.py
Root cause:1. If there is no any interacting between client and server for specific time(for example 5minutes),that leads server delete client‘s token,which client is not aware of that,when client rebuild a new watch,grpc server would return response,which response's create property is true,but cancle property also is true,in original etcd code that just judge create property,would regard this response as successful which would lead to the client thought watch request is successful, but in actually failed, therefore the client would never received any response any more. So in this fix,expose server watch cancel response as canceled exception to client to make it rebuild token
2. Fix in watcher run function handle exception part which lose control of lock part, therefore would cause concurrence problem