Modify TestWalk to not require the CWD be writable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a flag to specify the directory in which directory and file creation should be made. This presents a workaround to the assumption that the current working directory is writable.
|
Hmm, it's not so much an assumption as just the way it works. It's pretty common for a build process to put temporary files in the source directory. |
|
Sorry, heh. I appreciate the patch, I'm just trying to understand the motivation. When is the source directory of this package not writable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a flag to specify the directory in which directory and file
creation should be made. This presents a workaround to the assumption
that the current working directory is writable.