Allow MetaTagsCollection#update to recieve object #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2018 15:30
- If object responds to #to_meta_tags, call it. Otherwise, assume it's a Hash of meta tags and proceed as usual. - Allows set_meta_tags to receive an object that responds to to_meta_tags and just work
kpumuk
added a commit
that referenced
this pull request
Jun 8, 2018
…ve-an-object-responding-to-to_meta_tags Allow MetaTagsCollection#update to recieve object
|
Wow! That was fast! Thanks @kpumuk! Should I have bumped the gem version to 2.9.1 as well? |
|
I am updating docs and the build matrix (to include Rails 5.2). Will release shortly. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash of meta tags and proceed as usual.
to_meta_tags and just work
Closes #168