porch CLI: error instead of panic when the upstreamLock is not parseable #3938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an error instead of panicking in cases like #3933.
Sample output:
When using porch CLI, the upstreamLock.Git.Ref should be in the format of either
drafts/pkgname/workspace
orpkgname/version
. So we theoretically shouldn't run into any cases where there is no/
in upstreamLock.Git.Ref unless someone makes a change through something other than porch CLI. In these cases, we should throw an error that we are unable to parse the upstreamLock rather than panicking.