Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing license headers #3449

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

mortent
Copy link
Contributor

@mortent mortent commented Aug 9, 2022

We have some files that are missing the license headers. This causes unexpected changes when running make all. This PR excludes the cert-manager, ghost and ingress-nginx packages and updates the one remaining file that was missing the license.

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...So these manifests are actually sourced from cert-manager release bundle, so I am not sure if we want to use our license header on these. And the original manifests didn't have any license headers.

is it possible to skip certain directories from license-checks ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I've updated the PR to exclude the three packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mortent mortent merged commit fd748e1 into kptdev:main Aug 9, 2022
chunglu-chou pushed a commit to chunglu-chou/kpt that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants