Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.18 #3447

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Use go 1.18 #3447

merged 1 commit into from
Aug 10, 2022

Conversation

mortent
Copy link
Contributor

@mortent mortent commented Aug 8, 2022

This updates kpt and porch to use go 1.18.

@mortent mortent changed the title [WIP] Use go 1.19 Use go 1.19 Aug 8, 2022
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also have to update the docs where we list Go 1.17+ as the prerequisites (can be done as an immediate followup).

@mortent
Copy link
Contributor Author

mortent commented Aug 8, 2022

We'll hold off a little bit here since it impacts any downstream consumers of kpt.

@natasha41575
Copy link
Contributor

qq, do we plan to switch to go workspace mode as well?

@mengqiy
Copy link
Contributor

mengqiy commented Aug 9, 2022

I needs golang 1.18+ in #3450.

# github.com/prep/wasmexec
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/js.go:12:34: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/js.go:40:19: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/js.go:44:35: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/js.go:55:30: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/js.go:64:13: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:34:33: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:39:33: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:70:16: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:71:23: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:425:46: undefined: any
Error: ../../../go/pkg/mod/github.com/prep/wasmexec@v0.0.0-20220807105708-6554945c1dec/module.go:425:46: too many errors
note: module requires Go 1.18

Any ETA on this PR?

@mortent mortent force-pushed the UseGo1.19 branch 3 times, most recently from e623a75 to 0e8f62d Compare August 10, 2022 11:38
@mortent mortent changed the title Use go 1.19 Use go 1.18 Aug 10, 2022
@mortent
Copy link
Contributor Author

mortent commented Aug 10, 2022

Updated the PR to switch to 1.18 instead of 1.19. Got feedback that forcing downstream consumers to switch to the absolute latest version could be problematic. As far as I know we don't have a strong reason to prefer 1.19 over 1.18.

@droot @mengqiy

@natasha41575 We can use go workspaces, but we need to figure out how to be use it. Not sure if it will work well to check the workspace file into git.

Copy link
Contributor

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengqiy mengqiy merged commit 6e8b94a into kptdev:main Aug 10, 2022
chunglu-chou pushed a commit to chunglu-chou/kpt that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants