-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go 1.18 #3447
Use go 1.18 #3447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also have to update the docs where we list Go 1.17+ as the prerequisites (can be done as an immediate followup).
We'll hold off a little bit here since it impacts any downstream consumers of kpt. |
qq, do we plan to switch to go workspace mode as well? |
I needs golang 1.18+ in #3450.
Any ETA on this PR? |
e623a75
to
0e8f62d
Compare
Updated the PR to switch to 1.18 instead of 1.19. Got feedback that forcing downstream consumers to switch to the absolute latest version could be problematic. As far as I know we don't have a strong reason to prefer 1.19 over 1.18. @natasha41575 We can use go workspaces, but we need to figure out how to be use it. Not sure if it will work well to check the workspace file into git. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This updates kpt and porch to use go 1.18.