-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for ResourceGroup as inventory object (alpha) #1357
Conversation
fcb8e04
to
d4e7595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. Some minor comments.
|
||
```sh | ||
export RESOURCE_GROUP_INVENTORY=1 | ||
kpt live install-resource-group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that in a normal flow, kpt live init
automatically attempts to install the CRD, and failing that, this is the manual fallback, right? In the case, then you can just show the happy path and have this as an aside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I removed this example to the kpt live install-resource-group
. I added an explanation further down that the CRD is normally added as an initial step during kpt live apply
. Please let me know what you think.
|
||
[kpt live init](./init) | ||
|
||
### Troubleshooting and Verifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an error case when running kpt live apply
that tells the user to fall back to manual install of CRD? (Related to comment above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I used the kpt live apply
instead of kpt live install-resource-group
to illustrate the error. I added the command to manually install the CRD as the way to fix and verify the error. Please let me know what you think.
Apply ResourceGroup custom resource definition to the cluster | ||
--> | ||
|
||
**NOTE**: This command is not available unless the `RESOURCE_GROUP_INVENTORY` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth repeating here and for migrate command that this is only relevant for the alpha feature. Actually use the name of the relevant feature to tie these pages together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this initial NOTE to include the following:
This is an alpha command for the new ResourceGroup as inventory object
functionality
Please let me know if this is what you are looking for.
[**ConfigMap**](https://kubernetes.io/docs/concepts/configuration/configmap/) | ||
file (usually **inventory-template.yaml**). | ||
|
||
### Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed docs and examples. They're clear and helpful.
8cd098f
to
b675ee1
Compare
kpt live
command docs to upgrade to ResourceGroup as inventory (alpha). This adds a single line to the publicly accessible kpt documentation.kpt live migrate
andkpt live install-resource-group
. These commands are only accessible from minimally accessible ResourceGroup as inventory alpha instructions.kpt live init
command docs for ResourceGroup as inventory object (only accessible from minimally accessible alpha instructions documents).