Skip to content

Commit

Permalink
PR libstdc++/54562
Browse files Browse the repository at this point in the history
	* include/std/mutex (__timed_mutex_impl::__clock_t): Use
	high_resolution_clock for absolute timeouts, because
	pthread_mutex_timedlock uses CLOCK_REALTIME not CLOCK_MONOTONIC.
	(__timed_mutex_impl::_M_try_lock_for): Use steady_clock for relative
	timeouts as per [thread.req.timing].
	(__timed_mutex_impl::_M_try_lock_until<Clock,Duration>): Convert to
	__clock_t time point instead of using _M_try_lock_for.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@204672 138bc75d-0d04-0410-961f-82ee72b054a4
  • Loading branch information
redi committed Nov 11, 2013
1 parent f4f176b commit 4ca82f8
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 14 deletions.
11 changes: 11 additions & 0 deletions libstdc++-v3/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
2013-11-11 Jonathan Wakely <jwakely.gcc@gmail.com>

PR libstdc++/54562
* include/std/mutex (__timed_mutex_impl::__clock_t): Use
high_resolution_clock for absolute timeouts, because
pthread_mutex_timedlock uses CLOCK_REALTIME not CLOCK_MONOTONIC.
(__timed_mutex_impl::_M_try_lock_for): Use steady_clock for relative
timeouts as per [thread.req.timing].
(__timed_mutex_impl::_M_try_lock_until<Clock,Duration>): Convert to
__clock_t time point instead of using _M_try_lock_for.

2013-11-09 Jonathan Wakely <jwakely.gcc@gmail.com>

PR libstdc++/58982
Expand Down
24 changes: 10 additions & 14 deletions libstdc++-v3/include/std/mutex
Original file line number Diff line number Diff line change
Expand Up @@ -203,33 +203,26 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
class __timed_mutex_impl
{
protected:
#ifdef _GLIBCXX_USE_CLOCK_MONOTONIC
typedef chrono::steady_clock __clock_t;
#else
typedef chrono::high_resolution_clock __clock_t;
#endif

template<typename _Rep, typename _Period>
bool
_M_try_lock_for(const chrono::duration<_Rep, _Period>& __rtime)
{
auto __rt = chrono::duration_cast<__clock_t::duration>(__rtime);
if (ratio_greater<__clock_t::period, _Period>())
using chrono::steady_clock;
auto __rt = chrono::duration_cast<steady_clock::duration>(__rtime);
if (ratio_greater<steady_clock::period, _Period>())
++__rt;

return _M_try_lock_until(__clock_t::now() + __rt);
return _M_try_lock_until(steady_clock::now() + __rt);
}

template<typename _Duration>
bool
_M_try_lock_until(const chrono::time_point<__clock_t,
_Duration>& __atime)
{
chrono::time_point<__clock_t, chrono::seconds> __s =
chrono::time_point_cast<chrono::seconds>(__atime);

chrono::nanoseconds __ns =
chrono::duration_cast<chrono::nanoseconds>(__atime - __s);
auto __s = chrono::time_point_cast<chrono::seconds>(__atime);
auto __ns = chrono::duration_cast<chrono::nanoseconds>(__atime - __s);

__gthread_time_t __ts = {
static_cast<std::time_t>(__s.time_since_epoch().count()),
Expand All @@ -243,7 +236,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
template<typename _Clock, typename _Duration>
bool
_M_try_lock_until(const chrono::time_point<_Clock, _Duration>& __atime)
{ return _M_try_lock_for(__atime - _Clock::now()); }
{
auto __rtime = __atime - _Clock::now();
return _M_try_lock_until(__clock_t::now() + __rtime);
}
};

/// timed_mutex
Expand Down

0 comments on commit 4ca82f8

Please sign in to comment.