Skip to content

Commit

Permalink
Fix PR70182 -- missing "on" in mangling of unresolved operators
Browse files Browse the repository at this point in the history
The ABI says:

<unresolved-name>
   ::= [gs] <base-unresolved-name>
   ::= sr <unresolved-type> <base-unresolved-name>
   ::= srN <unresolved-type> <unresolved-qualifier-level>+ E <base-unresolved-name>
   ::= [gs] sr <unresolved-qualifier-level>+ E <base-unresolved-name>

<base-unresolved-name>
   ::= <simple-id>
   ::= on <operator-name>
   ::= on <operator-name> <template-args>
   ::= dn <destructor-name

libiberty:

	PR c++/70182
	* cp-demangle.c (d_unqualified_name): Handle "on" for
	operator names.
	* testsuite/demangle-expected: Add tests.

gcc/cp:

	PR c++/70182
	* mangle.c (write_template_args): Add "on" for operator names.

gcc:

	PR c++/70182
	* doc/invoke.texi (fabi-version): Mention mangling fix for
	operator names.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@244567 138bc75d-0d04-0410-961f-82ee72b054a4
  • Loading branch information
trippels committed Jan 18, 2017
1 parent a2929a3 commit 322066d
Show file tree
Hide file tree
Showing 11 changed files with 68 additions and 5 deletions.
6 changes: 6 additions & 0 deletions gcc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR c++/70182
* doc/invoke.texi (fabi-version): Mention mangling fix for
operator names.

2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR c++/77489
Expand Down
5 changes: 5 additions & 0 deletions gcc/cp/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR c++/70182
* mangle.c (write_template_args): Add "on" for operator names.

2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR c++/77489
Expand Down
6 changes: 6 additions & 0 deletions gcc/cp/mangle.c
Original file line number Diff line number Diff line change
Expand Up @@ -2817,6 +2817,12 @@ write_template_args (tree args)
static void
write_member_name (tree member)
{
if (abi_version_at_least (11) && IDENTIFIER_OPNAME_P (member))
{
write_string ("on");
if (abi_warn_or_compat_version_crosses (11))
G.need_abi_warning = 1;
}
if (identifier_p (member))
write_unqualified_id (member);
else if (DECL_P (member))
Expand Down
8 changes: 4 additions & 4 deletions gcc/doc/invoke.texi
Original file line number Diff line number Diff line change
Expand Up @@ -2252,10 +2252,10 @@ attributes that affect type identity, such as ia32 calling convention
attributes (e.g. @samp{stdcall}).

Version 11, which first appeared in G++ 7, corrects the mangling of
sizeof... expressions. For multiple entities with the same name within
a function, that are declared in different scopes, the mangling now
changes starting with the eighth occurence. It also implies
@option{-fnew-inheriting-ctors}.
sizeof... expressions and operator names. For multiple entities with
the same name within a function, that are declared in different scopes,
the mangling now changes starting with the eighth occurence. It also
implies @option{-fnew-inheriting-ctors}.

See also @option{-Wabi}.

Expand Down
2 changes: 1 addition & 1 deletion gcc/testsuite/g++.dg/abi/mangle13.C
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// { dg-options "-fabi-version=0" }
// { dg-options "-fabi-version=10" }

struct A {
template <typename T> int f ();
Expand Down
1 change: 1 addition & 0 deletions gcc/testsuite/g++.dg/abi/mangle37.C
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Testcase for mangling of expressions involving operator names.
// { dg-do compile { target c++11 } }
// { dg-options "-fabi-version=10" }
// { dg-final { scan-assembler "_Z1fI1AEDTclonplfp_fp_EET_" } }
// { dg-final { scan-assembler "_Z1gI1AEDTclonplIT_Efp_fp_EES1_" } }
// { dg-final { scan-assembler "_Z1hI1AEDTcldtfp_miEET_" } }
Expand Down
28 changes: 28 additions & 0 deletions gcc/testsuite/g++.dg/abi/pr70182.C
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// { dg-options "-fabi-version=0" }

struct A {
template <typename T> int f ();
int operator+();
operator int ();
template <typename T>
int operator-();
};

typedef int (A::*P)();

template <P> struct S {};

template <typename T> void g (S<&T::template f<int> >) {}
template <typename T> void g (S<&T::operator+ >) {}
template <typename T> void g (S<&T::operator int>) {}
template <typename T> void g (S<&T::template operator- <double> >) {}

template void g<A> (S<&A::f<int> >);
template void g<A> (S<&A::operator+>);
template void g<A> (S<&A::operator int>);
template void g<A> (S<&A::operator-<double> >);

// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_1fIiEEE } }
// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_onplEE } }
// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_oncviEE } }
// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_onmiIdEEE } }
1 change: 1 addition & 0 deletions gcc/testsuite/g++.dg/dfp/mangle-1.C
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// { dg-do compile }
// { dg-options "-fabi-version=10" }

// Mangling of classes from std::decimal are special-cased.
// Derived from g++.dg/abi/mangle13.C.
Expand Down
7 changes: 7 additions & 0 deletions libiberty/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR PR c++/70182
* cp-demangle.c (d_unqualified_name): Handle "on" for
operator names.
* testsuite/demangle-expected: Add tests.

2017-01-18 Markus Trippelsdorf <markus@trippelsdorf.de>

PR c++/77489
Expand Down
2 changes: 2 additions & 0 deletions libiberty/cp-demangle.c
Original file line number Diff line number Diff line change
Expand Up @@ -1594,6 +1594,8 @@ d_unqualified_name (struct d_info *di)
ret = d_source_name (di);
else if (IS_LOWER (peek))
{
if (peek == 'o' && d_peek_next_char (di) == 'n')
d_advance (di, 2);
ret = d_operator_name (di);
if (ret != NULL && ret->type == DEMANGLE_COMPONENT_OPERATOR)
{
Expand Down
7 changes: 7 additions & 0 deletions libiberty/testsuite/demangle-expected
Original file line number Diff line number Diff line change
Expand Up @@ -4682,3 +4682,10 @@ _ZZ3foovE8localVar__9_

_ZZ3foovE8localVar__12
_ZZ3foovE8localVar__12

# PR 70182
_Z1gI1AEv1SIXadsrT_onplEE
void g<A>(S<&A::operator+>)

_Z1gI1AEv1SIXadsrT_plEE
void g<A>(S<&A::operator+>)

0 comments on commit 322066d

Please sign in to comment.