Add tests for net player validation (diasurgical#6492)

kphoenix137 · Aug 20, 2023 · 7b06703 · 7b06703
1 parent eadfb85
commit 7b06703
Show file tree

Hide file tree

Showing 2 changed files with 565 additions and 3 deletions.
diff --git a/Source/pack.cpp b/Source/pack.cpp
@@ -96,11 +96,11 @@ bool IsCreationFlagComboValid(uint16_t iCreateInfo)
 	iCreateInfo = iCreateInfo & ~CF_LEVEL;
 	const bool isTownItem = (iCreateInfo & CF_TOWN) != 0;
 	const bool isPregenItem = (iCreateInfo & CF_PREGEN) != 0;
-	const bool isGroundItem = (iCreateInfo & CF_USEFUL) == CF_USEFUL;
+	const bool isUsefulItem = (iCreateInfo & CF_USEFUL) == CF_USEFUL;
 
-	if (isPregenItem && hasMultipleFlags(iCreateInfo))
+	if (isPregenItem)
 		return false;
-	if (isGroundItem && (iCreateInfo & ~CF_USEFUL) != 0)
+	if (isUsefulItem && (iCreateInfo & ~CF_USEFUL) != 0)
 		return false;
 	if (isTownItem && hasMultipleFlags(iCreateInfo))
 		return false;