Always set added and removed to true or false, rather than leaving them unset or explicitly using undefined
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aving them unset or explicitly using `undefined` Resolves #233
ryota-ka
added a commit
to ryota-ka/DefinitelyTyped
that referenced
this pull request
Oct 1, 2024
…teed to be set to a boolean value kpdecker/jsdiff#455
ryota-ka
added a commit
to ryota-ka/DefinitelyTyped
that referenced
this pull request
Oct 8, 2024
…teed to be set to a boolean value kpdecker/jsdiff#455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #233. I figure this makes the types returned by the library a bit simpler (
addedandremovedcan simply be considered always-present booleans rather than being boolean-or-undefined-or-maybe-omitted-entirely like they are now) which in turn makes it easier for someone to make sense of the values we returned, especially if they're not intimately familiar with jsdiff but reading code that uses jsdiff in an edit that shows them type definitions.(Obviously, actually having up-to-date type definitions is a further prerequisite for this change to be useful - hence I'd like to do #303, too, for the 6.0.0 release.)