Non-native fullscreen doesn't respect NSView.safeAreaInsets on displays with a notch

[dannydulai]

Bug description

When using macos_traditional_fullscreen yes, kitty renders content behind the display's safe area inset (i.e., behind the notch on MacBook models that have one). The content is physically obscured.

Expected behavior

macOS provides NSView.safeAreaInsets (available since macOS 12.0) which reports the exact insets needed to avoid hardware obstructions like the notch. In non-native fullscreen, the top inset is non-zero on notched displays and zero on everything else.

The content area should be offset by safeAreaInsets.top so that no text is rendered behind the notch.

Reproduction

1. Use a MacBook with a notch (2021+)
2. Set macos_traditional_fullscreen yes in kitty.conf
3. Toggle fullscreen — top lines of content are hidden behind the notch

Environment

• kitty 0.46.1
• macOS 15 (Sequoia) on a MacBook with a notch

[dannydulai]

I'd also like to offer a workaround to anyone who comes across this. If you save this kitten below and map it to Cmd-Enter, it'll do the right thing by dynamically changing the padding. It's ugly since it compiles a little swift program on first activation, but it does the job even if you have multi-monitor setups with some screens having notches and some without notches.

"""Kitten to toggle fullscreen and adjust padding for MacBook Pro notch."""

import os
import subprocess
import tempfile

KITTY_CONFIG_DIR = os.path.join(os.path.expanduser('~'), '.config', 'kitty')
NOTCH_DETECT_BIN = os.path.join(KITTY_CONFIG_DIR, '__native_notch_detect')
DEFAULT_PADDING = 4

SWIFT_SOURCE = '''\
import AppKit

let args = CommandLine.arguments
let wx = Double(args[1])!
let wy = Double(args[2])!

let primaryHeight = NSScreen.screens.first?.frame.height ?? 0
let point = NSPoint(x: wx, y: primaryHeight - wy)

var targetScreen = NSScreen.main ?? NSScreen.screens.first!
for screen in NSScreen.screens {
    if screen.frame.contains(point) {
        targetScreen = screen
        break
    }
}

let frame = targetScreen.frame
print(Int(frame.size.width))
print(Int(frame.size.height))
if #available(macOS 12.0, *) {
    print(Int(targetScreen.safeAreaInsets.top))
} else {
    print(0)
}
'''


def _ensure_binary():
    if os.path.isfile(NOTCH_DETECT_BIN):
        return
    fd, src_path = tempfile.mkstemp(suffix='.swift')
    try:
        with os.fdopen(fd, 'w') as f:
            f.write(SWIFT_SOURCE)
        subprocess.run(
            ['swiftc', src_path, '-o', NOTCH_DETECT_BIN, '-framework', 'AppKit'],
            check=True, timeout=30,
        )
    finally:
        os.unlink(src_path)


def main(args):
    pass


from kittens.tui.handler import result_handler


@result_handler(no_ui=True)
def handle_result(args, answer, target_window_id, boss):
    from kitty.fast_data_types import (
        current_focused_os_window_id,
        get_os_window_pos,
        get_os_window_size,
    )

    _ensure_binary()

    os_wid = current_focused_os_window_id()
    pos = get_os_window_pos(os_wid)
    boss.toggle_fullscreen()
    size = get_os_window_size(os_wid)

    screen_width, screen_height, notch_height = _detect_screen(pos[0], pos[1])

    is_fullscreen = size['width'] >= screen_width and size['height'] >= screen_height

    if is_fullscreen and notch_height > 0:
        _set_padding(boss, notch_height + 5)
    else:
        _set_padding(boss, DEFAULT_PADDING)


def _set_padding(boss, top):
    p = DEFAULT_PADDING
    boss.call_remote_control(None, (
        'set-spacing',
        f'padding-top={top}',
        f'padding-bottom={p}',
        f'padding-left={p}',
        f'padding-right={p}',
    ))


def _detect_screen(win_x, win_y):
    """Detect screen dimensions and notch height for the screen containing the window."""
    try:
        r = subprocess.run(
            [NOTCH_DETECT_BIN, str(win_x), str(win_y)],
            capture_output=True, text=True, timeout=5,
        )
        lines = r.stdout.strip().split('\n')
        return int(lines[0]), int(lines[1]), int(lines[2])
    except Exception:
        return 0, 0, 0

[kovidgoyal]

Not something I care to spend time on, given I dont even have the
hardware required to test it. I suggest you use regular fullscreen or
send a PR.

[dannydulai]

Yah, figured not everyone has hardware. Sent in a PR. Hope it works for you. Thanks